You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "emkornfield (via GitHub)" <gi...@apache.org> on 2024/05/24 18:14:19 UTC
[PR] PARQUET-2483: Update references to parquet-mr in dev script directory [parquet-java]
emkornfield opened a new pull request, #1358:
URL: https://github.com/apache/parquet-java/pull/1358
Make sure you have checked _all_ steps below.
### Jira
- [x ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Style
- [x ] My contribution adheres to the code style guidelines and Spotless passes.
- To apply the necessary changes, run `mvn spotless:apply -Pvector-plugins`
### Documentation
- [x ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] PARQUET-2483: Update references to parquet-mr in Readmes [parquet-java]
Posted by "emkornfield (via GitHub)" <gi...@apache.org>.
emkornfield commented on code in PR #1358:
URL: https://github.com/apache/parquet-java/pull/1358#discussion_r1615013171
##########
README.md:
##########
@@ -17,7 +17,7 @@
~ under the License.
-->
-Parquet MR [](https://github.com/apache/parquet-mr/actions)
+Parquet MR [](https://github.com/apache/parquet-mr/actions)
Review Comment:
I think I did this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] PARQUET-2483: Update references to parquet-mr in Readmes [parquet-java]
Posted by "emkornfield (via GitHub)" <gi...@apache.org>.
emkornfield closed pull request #1358: PARQUET-2483: Update references to parquet-mr in Readmes
URL: https://github.com/apache/parquet-java/pull/1358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] PARQUET-2483: Update references to parquet-mr in Readmes [parquet-java]
Posted by "emkornfield (via GitHub)" <gi...@apache.org>.
emkornfield commented on PR #1358:
URL: https://github.com/apache/parquet-java/pull/1358#issuecomment-2143513115
If no objections I can Squash merge this and resolve the jira by hand?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] PARQUET-2483: Update references to parquet-mr in Readmes [parquet-java]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #1358:
URL: https://github.com/apache/parquet-java/pull/1358#discussion_r1620004482
##########
README.md:
##########
@@ -36,7 +36,7 @@ You can find additional details about the format and intended use cases in our [
## Building
-Parquet-MR uses Maven to build and depends on the thrift compiler (protoc is now managed by maven plugin).
+Parquet-java uses Maven to build and depends on the thrift compiler (protoc is now managed by maven plugin).
Review Comment:
To be more consistent with the casing:
```suggestion
Parquet-Java uses Maven to build and depends on the thrift compiler (protoc is now managed by maven plugin).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] PARQUET-2483: Update references to parquet-mr in Readmes [parquet-java]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #1358:
URL: https://github.com/apache/parquet-java/pull/1358#discussion_r1614402839
##########
README.md:
##########
@@ -17,7 +17,7 @@
~ under the License.
-->
-Parquet MR [](https://github.com/apache/parquet-mr/actions)
+Parquet MR [](https://github.com/apache/parquet-mr/actions)
Review Comment:
```suggestion
Parquet Java [](https://github.com/apache/parquet-mr/actions)
```
##########
README.md:
##########
@@ -17,7 +17,7 @@
~ under the License.
-->
-Parquet MR [](https://github.com/apache/parquet-mr/actions)
+Parquet MR [](https://github.com/apache/parquet-mr/actions)
Review Comment:
Should we also change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org