[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #1980: io.shardingjdbc.core.routing.strategy.hint.HintShardingStrategy#shardingColumns will not setting anyway

[GitBox <gi...@apache.org>]

tristaZero edited a comment on issue #1980: io.shardingjdbc.core.routing.strategy.hint.HintShardingStrategy#shardingColumns will not setting anyway
URL: https://github.com/apache/incubator-shardingsphere/issues/1980#issuecomment-470393392
 
 
   @wayne0zhang which version do you use?
   In latest version, i.e.,4.0.0.M1-SNAPSHOT,
   ```
   package org.apache.shardingsphere.core.routing.type.standard;
   
   private List<RouteValue> getTableShardingValuesFromHint() {
           return getRouteValues(HintManagerHolder.getTableShardingValues(logicTableName));
       }
   ```
   We get shardingValues from HintManagerHolder, where user puts shardingValues. And then we will pass shardingValues to doSharding() in HintShardingAlgorithm, and calculate the target tables by calling doSharding() in HintShardingAlgorithm.
   
   ***Therefore, shardingColumns in HintShardingStrategy will not be used, but doSharding() in HintShardingAlgorithm will be called anyway.***

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services