You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2022/11/09 14:35:06 UTC
[GitHub] [celix] stegemr commented on a diff in pull request #388: Feature/embedded bundles
stegemr commented on code in PR #388:
URL: https://github.com/apache/celix/pull/388#discussion_r1018018241
##########
bundles/shell/shell/gtest/CMakeLists.txt:
##########
@@ -20,8 +20,7 @@ add_executable(test_shell
)
target_link_libraries(test_shell PRIVATE Celix::framework Celix::shell_api GTest::gtest GTest::gtest_main)
-add_celix_bundle_dependencies(test_shell shell)
-target_compile_definitions(test_shell PRIVATE -DSHELL_BUNDLE_LOCATION=\"$<TARGET_PROPERTY:shell,BUNDLE_FILE>\")
+celix_target_bundle_set_definition(test_shell NAME TEST_BUNDLES Celix::shell)
Review Comment:
What does "TEST_BUNDLES" add here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org