[Patch] make davautocheck working.

[Marcus Rueckert <da...@web.de>]

hi, 

we tried "make davautocheck" this night and it failed horribly.

1. it assumed that username and groupname match. this might be true on
some systems but not on all.

2. it used apache configuration directives without loading needed
modules.

The patch fixes those 2 issues. I tried to make the auth module check
working for apache 2.1 too.

The current patch is against 1.2.x branch. Will fix it for trunk and
submit it too.

darix

Re: [Patch] make davautocheck working.

["Peter N. Lundblad" <pe...@famlundblad.se>]

On Fri, 13 May 2005, Marcus Rueckert wrote:

> hi
>
> patch v3.
>
> after a bit testing with vksameer, we found out that the check in line
> 170 was a bit too hard if mod_auth was compiled in.
>
> log message
> [[[
> Load the authentication modules and mime type module if needed before
> using their directives in the config file. Do not assume that group name
> matches the username.
>
In r14777.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [Patch] make davautocheck working.

["Peter N. Lundblad" <pe...@famlundblad.se>]

On Fri, 13 May 2005, Marcus Rueckert wrote:

> after a bit testing with vksameer, we found out that the check in line
> 170 was a bit too hard if mod_auth was compiled in.
>
> last but not least some question:
>
> how hard would it be to teach configure about "apxs2"? it would be cool
> that configure and "make davautocheck" behave the same.
>
Maybe not harder than the attached patch. Maybe we can get rid of the
detection in davautocheck.sh now (and possibly generate it from
davautocheck.sh.in?)?

Best,
//Peter

Re: [Patch] make davautocheck working.

[Marcus Rueckert <da...@web.de>]

hi

patch v3.

after a bit testing with vksameer, we found out that the check in line
170 was a bit too hard if mod_auth was compiled in.

log message
[[[
Load the authentication modules and mime type module if needed before
using their directives in the config file. Do not assume that group name
matches the username.

* subversion/tests/clients/cmdline/davautocheck.sh:
    added check for mod_mime.
    added check for mod_auth on Apache 2.0
    added check for mod_auth_basic and mod_authn_file for Apache 2.1
    fixed group detection
    fixed order of directives in the config file
]]]

last but not least some question:

why do we load the mimetypes file at all? does mod_dav_svn use it?

how hard would it be to teach configure about "apxs2"? it would be cool
that configure and "make davautocheck" behave the same.

darix

Re: [Patch] make davautocheck working.

[Marcus Rueckert <da...@web.de>]

On 2005-05-13 04:32:21 +0200, Marcus Rueckert wrote:
> The current patch is against 1.2.x branch. Will fix it for trunk and
> submit it too.

as i promised. the patch against trunk. it fixes the apache 2.1 issues
aswell. i would propose to apply this patch to trunk and merge it to
1.2.

hope this helps

darix