[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #560: Optimize Dynamic Config with ActiveTimeSeriesCounter

[GitBox <gi...@apache.org>]

fanhualta commented on a change in pull request #560: Optimize Dynamic Config with ActiveTimeSeriesCounter
URL: https://github.com/apache/incubator-iotdb/pull/560#discussion_r348253825
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/service/IoTDB.java
 ##########
 @@ -107,6 +100,13 @@ private void setUp() throws StartupException {
     registerManager.register(MetricsService.getInstance());
     JMXService.registerMBean(getInstance(), mbeanName);
 
+    // When registering statMonitor, we should start recovering some statistics
+    // with latest values stored
+    // Warn: registMonitor() method should be called after systemDataRecovery()
+    if (IoTDBDescriptor.getInstance().getConfig().isEnableStatMonitor()) {
+      StatMonitor.getInstance().recovery();
+    }
+
 
 Review comment:
   Why you put these codes here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services