[GitHub] [druid] imply-cheddar commented on pull request #13051: improve nested column serializer

[GitBox <gi...@apache.org>]

imply-cheddar commented on PR #13051:
URL: https://github.com/apache/druid/pull/13051#issuecomment-1240161017

   Meta commentary: I've been trying to review this, the changes are quite surgical to a set of classes that are all private static classes laid out in one long file.  This is making it really hard to review as the diff lines lose the context of which class I'm looking at and I have to click on the arrows and stuff to try to keep track of which class I'm in.  Can we move all of the different writers into their own files?  E.g.
   
   ```
   private final class StringFieldColumnWriter extends GlobalDictionaryEncodedFieldColumnWriter<String>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org