You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "James Dyer (Created) (JIRA)" <ji...@apache.org> on 2012/03/21 19:37:40 UTC
[jira] [Created] (SOLR-3262) Remove "threads" from DIH (Trunk only)
Remove "threads" from DIH (Trunk only)
--------------------------------------
Key: SOLR-3262
URL: https://issues.apache.org/jira/browse/SOLR-3262
Project: Solr
Issue Type: Bug
Components: contrib - DataImportHandler
Affects Versions: 4.0
Reporter: James Dyer
Assignee: James Dyer
Priority: Minor
Fix For: 4.0
SOLR-1352 introduced a multi-threading feature for DataImportHandler. Historically, this feature only seemed to work in a limited set of cases and I don't think we can guarantee users that using "threads" will behave consistently. Also, the multi-threaded option adds considerable complexity making code refactoring difficult.
I propose removing "threads" from Trunk. (But keep it in 3.x, applying any bug fixes for it there.) This can be a first step in improving the DIH code base.
Eventually we can possibly add a carefully though-out "threads" implementation back in.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3262) Remove "threads" from DIH (Trunk
only)
Posted by "Koji Sekiguchi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235289#comment-13235289 ]
Koji Sekiguchi commented on SOLR-3262:
--------------------------------------
+1
> Remove "threads" from DIH (Trunk only)
> --------------------------------------
>
> Key: SOLR-3262
> URL: https://issues.apache.org/jira/browse/SOLR-3262
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.0
>
>
> SOLR-1352 introduced a multi-threading feature for DataImportHandler. Historically, this feature only seemed to work in a limited set of cases and I don't think we can guarantee users that using "threads" will behave consistently. Also, the multi-threaded option adds considerable complexity making code refactoring difficult.
> I propose removing "threads" from Trunk. (But keep it in 3.x, applying any bug fixes for it there.) This can be a first step in improving the DIH code base.
> Eventually we can possibly add a carefully though-out "threads" implementation back in.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3262) Remove "threads" from DIH (Trunk
only)
Posted by "James Dyer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237024#comment-13237024 ]
James Dyer commented on SOLR-3262:
----------------------------------
Patch to remove "threads" from DIH. I would like to commit this in a few days.
> Remove "threads" from DIH (Trunk only)
> --------------------------------------
>
> Key: SOLR-3262
> URL: https://issues.apache.org/jira/browse/SOLR-3262
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3262.patch
>
>
> SOLR-1352 introduced a multi-threading feature for DataImportHandler. Historically, this feature only seemed to work in a limited set of cases and I don't think we can guarantee users that using "threads" will behave consistently. Also, the multi-threaded option adds considerable complexity making code refactoring difficult.
> I propose removing "threads" from Trunk. (But keep it in 3.x, applying any bug fixes for it there.) This can be a first step in improving the DIH code base.
> Eventually we can possibly add a carefully though-out "threads" implementation back in.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3262) Remove "threads" from DIH (Trunk only)
Posted by "James Dyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer updated SOLR-3262:
-----------------------------
Attachment: SOLR-3262.patch
> Remove "threads" from DIH (Trunk only)
> --------------------------------------
>
> Key: SOLR-3262
> URL: https://issues.apache.org/jira/browse/SOLR-3262
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3262.patch
>
>
> SOLR-1352 introduced a multi-threading feature for DataImportHandler. Historically, this feature only seemed to work in a limited set of cases and I don't think we can guarantee users that using "threads" will behave consistently. Also, the multi-threaded option adds considerable complexity making code refactoring difficult.
> I propose removing "threads" from Trunk. (But keep it in 3.x, applying any bug fixes for it there.) This can be a first step in improving the DIH code base.
> Eventually we can possibly add a carefully though-out "threads" implementation back in.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3262) Remove "threads" from DIH (Trunk
only)
Posted by "Chris Male (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235290#comment-13235290 ]
Chris Male commented on SOLR-3262:
----------------------------------
+1
I think this should be a big priority for 4.0, so we don't release the code again.
> Remove "threads" from DIH (Trunk only)
> --------------------------------------
>
> Key: SOLR-3262
> URL: https://issues.apache.org/jira/browse/SOLR-3262
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.0
>
>
> SOLR-1352 introduced a multi-threading feature for DataImportHandler. Historically, this feature only seemed to work in a limited set of cases and I don't think we can guarantee users that using "threads" will behave consistently. Also, the multi-threaded option adds considerable complexity making code refactoring difficult.
> I propose removing "threads" from Trunk. (But keep it in 3.x, applying any bug fixes for it there.) This can be a first step in improving the DIH code base.
> Eventually we can possibly add a carefully though-out "threads" implementation back in.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3262) Remove "threads" from DIH (Trunk
only)
Posted by "James Dyer (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer resolved SOLR-3262.
------------------------------
Resolution: Fixed
committed. Trunk: r1305384
> Remove "threads" from DIH (Trunk only)
> --------------------------------------
>
> Key: SOLR-3262
> URL: https://issues.apache.org/jira/browse/SOLR-3262
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3262.patch
>
>
> SOLR-1352 introduced a multi-threading feature for DataImportHandler. Historically, this feature only seemed to work in a limited set of cases and I don't think we can guarantee users that using "threads" will behave consistently. Also, the multi-threaded option adds considerable complexity making code refactoring difficult.
> I propose removing "threads" from Trunk. (But keep it in 3.x, applying any bug fixes for it there.) This can be a first step in improving the DIH code base.
> Eventually we can possibly add a carefully though-out "threads" implementation back in.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org