You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/24 20:20:47 UTC

[GitHub] [incubator-tvm] yzhliu edited a comment on issue #4765: [tir] make IterVar extends Var

yzhliu edited a comment on issue #4765: [tir] make IterVar extends Var
URL: https://github.com/apache/incubator-tvm/pull/4765#issuecomment-578281104
 
 
   @tqchen another problem is currently we rely on `IterVar->var` to propagate variables from the very beginning, e.g., 
   ```
   rv = tvm.reduce_axis(...)
   Y = sum(X[rv], axis=rv)
   ```
   
   However, `rv` could be replaced during the pass, it cause problem when we use the original `rv` to access array 
   
   one example of replacing: https://github.com/apache/incubator-tvm/blob/master/src/tir/ir/expr_functor.cc#L206-L208
   
   rethink about the scenario, I feel it is actually not a bad idea to have `Var` as a member of `IterVar`,  it simplifies the problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services