You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/01/06 18:54:39 UTC
[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4259: Internal
Server Error when assigning federation resolver id that doesn't exist
ZugNZwang opened a new issue #4259: Internal Server Error when assigning federation resolver id that doesn't exist
URL: https://github.com/apache/trafficcontrol/issues/4259
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
<!--
- For *SUPPORT QUESTIONS*, use the
[Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->
## I'm submitting a ...
<!-- (check all that apply with "[x]") -->
<!--- security vulnerability (STOP!! - see above)-->
- [X] bug report
- [ ] new feature / enhancement request
- [ ] improvement request (usability, performance, tech debt, etc.)
- [ ] other <!--(Please do not submit support requests here - see above)-->
## Traffic Control components affected ...
<!-- (check all that apply with "[x]") -->
- [ ] CDN in a Box
- [ ] Documentation
- [ ] Grove
- [ ] Traffic Control Client
- [ ] Traffic Monitor
- [X] Traffic Ops
- [ ] Traffic Ops ORT
- [ ] Traffic Portal
- [ ] Traffic Router
- [ ] Traffic Stats
- [ ] Traffic Vault
- [ ] unknown
## Current behavior:
<!-- Describe how the bug manifests / how the current features are insufficient. -->
When making a `POST` request to `federations/{{id}}/federation_resolvers` with the request body:
```
{
"fedResolverIds": [201]
}
```
Where the id given in the array doesn't exit/pertain to any federation resolver.
The response returned is:
```
HTTP/1.1 500 Internal Server Error
{
"alerts": [
{
"text": "Internal Server Error",
"level": "error"
}
]
}
```
## Expected / new behavior:
<!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control -->
Should return:
```
HTTP/1.1 404 Not Found
{
"alerts": [
{
"text": "federation resolver does not exist",
"level": "error"
}
]
}
```
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example,
please provide the *STEPS TO REPRODUCE* and include the applicable TC version.
-->
## Anything else:
<!-- e.g. stacktraces, related issues, suggestions how to fix -->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mhoppa commented on issue #4259: Internal Server
Error when assigning federation resolver id that doesn't exist
Posted by GitBox <gi...@apache.org>.
mhoppa commented on issue #4259: Internal Server Error when assigning federation resolver id that doesn't exist
URL: https://github.com/apache/trafficcontrol/issues/4259#issuecomment-571326699
I vote for `404`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 commented on issue #4259: Internal
Server Error when assigning federation resolver id that doesn't exist
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4259: Internal Server Error when assigning federation resolver id that doesn't exist
URL: https://github.com/apache/trafficcontrol/issues/4259#issuecomment-571311825
I'm not sure if this should be a:
400 Bad Request - "Invalid resolver id(s) provided" or
404 Not Found - "Resolver not found"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4259:
Internal Server Error when assigning federation resolver id that doesn't
exist
Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #4259: Internal Server Error when assigning federation resolver id that doesn't exist
URL: https://github.com/apache/trafficcontrol/issues/4259#issuecomment-571672506
409 sounds great for api v3.x imo. 404 for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on issue #4259: Internal
Server Error when assigning federation resolver id that doesn't exist
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4259: Internal Server Error when assigning federation resolver id that doesn't exist
URL: https://github.com/apache/trafficcontrol/issues/4259#issuecomment-571336677
404 is fine IMO, but also 409 :eyes:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 commented on issue #4259: Internal
Server Error when assigning federation resolver id that doesn't exist
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4259: Internal Server Error when assigning federation resolver id that doesn't exist
URL: https://github.com/apache/trafficcontrol/issues/4259#issuecomment-571672506
409 sounds great for api v3.x imo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ZugNZwang commented on issue #4259: Internal
Server Error when assigning federation resolver id that doesn't exist
Posted by GitBox <gi...@apache.org>.
ZugNZwang commented on issue #4259: Internal Server Error when assigning federation resolver id that doesn't exist
URL: https://github.com/apache/trafficcontrol/issues/4259#issuecomment-571314294
I based it off of the `server_server_capabilities` endpoint, when providing a server id that doesn't exist to this endpoint, it returns a `404` and an alert saying `"server 1000000 does not exist"`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services