You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Jon Scott Stevens <jo...@latchkey.com> on 2002/01/06 21:28:32 UTC

Re: cvs commit: jakarta-commons/validator/src/share/org/apache/commons/validator Arg.java Constant.java DefaultValidatorLog.java Field.java Form.java FormSet.java GenericValidator.java Msg.java Validator.java ValidatorAction.java ValidatorException.java ValidatorLog.java ValidatorResources.java ValidatorResourcesInitializer.java ValidatorUtil.java Var.java

on 1/5/02 9:08 PM, "dwinterfeldt@apache.org" <dw...@apache.org>
wrote:

>            if (indexedListProperty != null)
>               field.setIndexedListProperty(new String(indexedListProperty));

Bad coding style.

-jon


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: cvs commit:jakarta-commons/validator/src/share/org/apache/commons/validator Arg.javaConstant.java DefaultValidatorLog.java Field.java Form.java FormSet.javaGenericValidator.java Msg.java Validator.java ValidatorAction.javaValidatorException.java ValidatorLog.java ValidatorResources.javaValidatorResourcesInitializer.java ValidatorUtil.java Var.java

Posted by Ted Husted <hu...@apache.org>.
There was a long discussion on General, where we realized that we were
drifting away from the standard conventions. So some of us, like Jon and
I, are volunteering to nag people when we notice anything awry. 

The preferred style is to always enclose if-else blocks in braces, to
avoid problems when another statement is added later. I'm forever
forgetting to do this myself. Both Sun and The Elements of Java Style
advocate this.

-Ted.


Jon Scott Stevens wrote:
> 
> Sigh. We just went over this...
> 
> <http://jakarta.apache.org/site/source.html>
> 
> -jon
> 
> on 1/6/02 12:45 PM, "David Winterfeldt" <dw...@yahoo.com> wrote:
> 
> > What would the preferred style be?
> >
> > David
> >
> > --- Jon Scott Stevens <jo...@latchkey.com> wrote:
> >> on 1/5/02 9:08 PM, "dwinterfeldt@apache.org"
> >> <dw...@apache.org>
> >> wrote:
> >>
> >>>            if (indexedListProperty != null)
> >>>               field.setIndexedListProperty(new
> >> String(indexedListProperty));
> >>
> >> Bad coding style.
> >>
> >> -jon

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: cvs commit: jakarta-commons/validator/src/share/org/apache/commons/validator Arg.java Constant.java DefaultValidatorLog.java Field.java Form.java FormSet.java GenericValidator.java Msg.java Validator.java ValidatorAction.java ValidatorException.java ValidatorLog.java ValidatorResources.java ValidatorResourcesInitializer.java ValidatorUtil.java Var.java

Posted by Jon Scott Stevens <jo...@latchkey.com>.
Sigh. We just went over this...

<http://jakarta.apache.org/site/source.html>

-jon

on 1/6/02 12:45 PM, "David Winterfeldt" <dw...@yahoo.com> wrote:

> What would the preferred style be?
> 
> David
> 
> --- Jon Scott Stevens <jo...@latchkey.com> wrote:
>> on 1/5/02 9:08 PM, "dwinterfeldt@apache.org"
>> <dw...@apache.org>
>> wrote:
>> 
>>>            if (indexedListProperty != null)
>>>               field.setIndexedListProperty(new
>> String(indexedListProperty));
>> 
>> Bad coding style.
>> 
>> -jon


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: cvs commit: jakarta-commons/validator/src/share/org/apache/commons/validator Arg.java Constant.java DefaultValidatorLog.java Field.java Form.java FormSet.java GenericValidator.java Msg.java Validator.java ValidatorAction.java ValidatorException.java ValidatorLog.java ValidatorResources.java ValidatorResourcesInitializer.java ValidatorUtil.java Var.java

Posted by David Winterfeldt <dw...@yahoo.com>.
What would the preferred style be?

David

--- Jon Scott Stevens <jo...@latchkey.com> wrote:
> on 1/5/02 9:08 PM, "dwinterfeldt@apache.org"
> <dw...@apache.org>
> wrote:
> 
> >            if (indexedListProperty != null)
> >               field.setIndexedListProperty(new
> String(indexedListProperty));
> 
> Bad coding style.
> 
> -jon
> 
> 
> --
> To unsubscribe, e-mail:  
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
> 


__________________________________________________
Do You Yahoo!?
Send FREE video emails in Yahoo! Mail!
http://promo.yahoo.com/videomail/

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>