You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jayapal Reddy <ja...@citrix.com> on 2013/04/22 13:10:29 UTC
Review Request: updated the listnics response for non-root user
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10703/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
Description
-------
Updated listnics response for normal user
This addresses bug CLOUDSTACK-1573.
Diffs
-----
server/src/com/cloud/api/ApiResponseHelper.java a7d6165
Diff: https://reviews.apache.org/r/10703/diff/
Testing
-------
Tested with admin and normal user
Thanks,
Jayapal Reddy
Re: Review Request: updated the listnics response for non-root user
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10703/#review19695
-----------------------------------------------------------
Ship it!
Ship It!
- Murali Reddy
On April 25, 2013, 7:06 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10703/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 7:06 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
>
>
> Description
> -------
>
> Updated listnics response for normal user
>
>
> This addresses bug CLOUDSTACK-1573.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/ApiResponseHelper.java 894ec8d
>
> Diff: https://reviews.apache.org/r/10703/diff/
>
>
> Testing
> -------
>
> Tested with admin and normal user
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: updated the listnics response for non-root user
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10703/
-----------------------------------------------------------
(Updated April 25, 2013, 7:06 a.m.)
Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
Changes
-------
updated ipv6 in response
Description
-------
Updated listnics response for normal user
This addresses bug CLOUDSTACK-1573.
Diffs (updated)
-----
server/src/com/cloud/api/ApiResponseHelper.java 894ec8d
Diff: https://reviews.apache.org/r/10703/diff/
Testing
-------
Tested with admin and normal user
Thanks,
Jayapal Reddy
Re: Review Request: updated the listnics response for non-root user
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10703/#review19692
-----------------------------------------------------------
server/src/com/cloud/api/ApiResponseHelper.java
<https://reviews.apache.org/r/10703/#comment40643>
if IPv6 address is present then setIpv6 address in the nic response.
- Murali Reddy
On April 25, 2013, 5:03 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10703/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 5:03 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
>
>
> Description
> -------
>
> Updated listnics response for normal user
>
>
> This addresses bug CLOUDSTACK-1573.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/ApiResponseHelper.java cd0158d
>
> Diff: https://reviews.apache.org/r/10703/diff/
>
>
> Testing
> -------
>
> Tested with admin and normal user
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: updated the listnics response for non-root user
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10703/
-----------------------------------------------------------
(Updated April 25, 2013, 5:03 a.m.)
Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
Changes
-------
Removed vlan info and added network id
Description
-------
Updated listnics response for normal user
This addresses bug CLOUDSTACK-1573.
Diffs (updated)
-----
server/src/com/cloud/api/ApiResponseHelper.java cd0158d
Diff: https://reviews.apache.org/r/10703/diff/
Testing
-------
Tested with admin and normal user
Thanks,
Jayapal Reddy
Re: Review Request: updated the listnics response for non-root user
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10703/#review19617
-----------------------------------------------------------
server/src/com/cloud/api/ApiResponseHelper.java
<https://reviews.apache.org/r/10703/#comment40528>
I don't think we should be passing VLAN information in NicResponse.
Its important that we pass network ID to which this NIC belong. I dont see network id being set in the nic response.
- Murali Reddy
On April 22, 2013, 11:10 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10703/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 11:10 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
>
>
> Description
> -------
>
> Updated listnics response for normal user
>
>
> This addresses bug CLOUDSTACK-1573.
>
>
> Diffs
> -----
>
> server/src/com/cloud/api/ApiResponseHelper.java a7d6165
>
> Diff: https://reviews.apache.org/r/10703/diff/
>
>
> Testing
> -------
>
> Tested with admin and normal user
>
>
> Thanks,
>
> Jayapal Reddy
>
>