You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "LDeakin (via GitHub)" <gi...@apache.org> on 2026/07/21 13:10:48 UTC
[PR] fix: restore 1.85 MSRV and fix MSRV CI [arrow-rs-object-store]
LDeakin opened a new pull request, #812:
URL: https://github.com/apache/arrow-rs-object-store/pull/812
Closes https://github.com/apache/arrow-rs-object-store/issues/811
This just avoids using let chains, which were introduced in 1.88 or something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: restore 1.85 MSRV and fix MSRV CI [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #812:
URL: https://github.com/apache/arrow-rs-object-store/pull/812#issuecomment-5319913063
Thank you @LDeakin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: restore 1.85 MSRV and fix MSRV CI [arrow-rs-object-store]
Posted by "progval (via GitHub)" <gi...@apache.org>.
progval commented on PR #812:
URL: https://github.com/apache/arrow-rs-object-store/pull/812#issuecomment-5061268463
I also get this compilation error on 1.85:
```
error[E0599]: no function or associated item named `from_utf8` found for type `str` in the current scope
--> src/parse.rs:477:25
|
477 | let body = str::from_utf8(&body).unwrap();
| ^^^^^^^^^ function or associated item not found in `str`
|
help: you are looking for the module in `std`, not the primitive type
|
477 | let body = std::str::from_utf8(&body).unwrap();
| +++++
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: restore 1.85 MSRV and fix MSRV CI [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #812:
URL: https://github.com/apache/arrow-rs-object-store/pull/812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: restore 1.85 MSRV and fix MSRV CI [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #812:
URL: https://github.com/apache/arrow-rs-object-store/pull/812#issuecomment-5320022594
> I also get this compilation error on 1.85:
>
> ```
> error[E0599]: no function or associated item named `from_utf8` found for type `str` in the current scope
> --> src/parse.rs:477:25
> |
> 477 | let body = str::from_utf8(&body).unwrap();
> | ^^^^^^^^^ function or associated item not found in `str`
> |
> help: you are looking for the module in `std`, not the primitive type
> |
> 477 | let body = std::str::from_utf8(&body).unwrap();
> | +++++
> ```
I think the error is that the tests are not included in
```
cargo +1.85 check --all-features
```
We need to add the `--all-targets` to have the tests included too. I will make a PR to do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: restore 1.85 MSRV and fix MSRV CI [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #812:
URL: https://github.com/apache/arrow-rs-object-store/pull/812#issuecomment-5320255262
We need to add the --all-targets to have the tests included too. I will make a PR to do this
- PR created: https://github.com/apache/arrow-rs-object-store/pull/837
I also made another PR to speed up this CI check:
- https://github.com/apache/arrow-rs-object-store/pull/838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org