You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/05/26 13:16:24 UTC

[GitHub] [incubator-pekko-http] pjfanning opened a new pull request, #155: fix more issues with legacy Akka naming

pjfanning opened a new pull request, #155:
URL: https://github.com/apache/incubator-pekko-http/pull/155

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #155: fix more issues with legacy Akka naming

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #155:
URL: https://github.com/apache/incubator-pekko-http/pull/155#issuecomment-1564392855

   @pjfanning Apologies but my javafmt commit caused some merge conflicts on this PR but they are relatively minor. If you do a rebase on `origin/main` and run `sbt javafmt` it should remove the conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #155: fix more issues with legacy Akka naming

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #155:
URL: https://github.com/apache/incubator-pekko-http/pull/155#issuecomment-1564435705

   Noted, I will check it after I fix the pekko docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] pjfanning merged pull request #155: fix more issues with legacy Akka naming

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #155:
URL: https://github.com/apache/incubator-pekko-http/pull/155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] pjfanning commented on pull request #155: fix more issues with legacy Akka naming

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #155:
URL: https://github.com/apache/incubator-pekko-http/pull/155#issuecomment-1564432060

   @mdedetrich no hurry on merging this but I think it is safe to merge and that it doesn't have any effect (good or bad) on the scaladoc generation issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #155: fix more issues with legacy Akka naming

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #155:
URL: https://github.com/apache/incubator-pekko-http/pull/155#issuecomment-1564395127

   Do you want this to be reviewed, you didn't assign any reviewers?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] pjfanning commented on pull request #155: fix more issues with legacy Akka naming

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #155:
URL: https://github.com/apache/incubator-pekko-http/pull/155#issuecomment-1564405685

   I typically wait for a clean CI run before assigning reviewers


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] pjfanning commented on pull request #155: fix more issues with legacy Akka naming

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #155:
URL: https://github.com/apache/incubator-pekko-http/pull/155#issuecomment-1564394028

   @mdedetrich I was aware that it would happen. I have fixed the merge conflicts now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org