You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/11 07:22:21 UTC
[GitHub] [hudi] voonhous opened a new pull request, #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
voonhous opened a new pull request, #6920:
URL: https://github.com/apache/hudi/pull/6920
…orming a LATEST streaming read
### Change Logs
Prevent Hudi from performing unnecessary file scans when performing a stream read from the latest instant.
### Impact
_Describe any public API or user-facing feature change or any performance impact._
**Risk level: none | low | medium | high**
_Choose one. If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1328016089
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
}, {
"hash" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423",
"triggerID" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"triggerType" : "PUSH"
}, {
"hash" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13243",
"triggerID" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"triggerType" : "PUSH"
}, {
"hash" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"triggerType" : "PUSH"
}, {
"hash" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13245",
"triggerID" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"triggerType" : "PUSH"
}, {
"hash" : "c9060e7436ede0d2e719beeca8bbcd2dad147525",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c9060e7436ede0d2e719beeca8bbcd2dad147525",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdf960d7a22544a0da5587441f99bd49aa9cca98 UNKNOWN
* 058d52ea7c48c665acdd2c124ca356bcfa5599f7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13245)
* c9060e7436ede0d2e719beeca8bbcd2dad147525 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #6920:
URL: https://github.com/apache/hudi/pull/6920#discussion_r1033156381
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -474,7 +474,7 @@ private HoodieTimeline getArchivedReadTimeline(HoodieTableMetaClient metaClient,
* @param issuedInstant The last issued instant that has already been delivered to downstream
* @return the filtered hoodie instants
*/
- private List<HoodieInstant> filterInstantsWithRange(
+ public List<HoodieInstant> filterInstantsWithRange(
Review Comment:
Add the tag `@VisibleForTesting`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1327397664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
}, {
"hash" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423",
"triggerID" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"triggerType" : "PUSH"
}, {
"hash" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13243",
"triggerID" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"triggerType" : "PUSH"
}, {
"hash" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"triggerType" : "PUSH"
}, {
"hash" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 907782ea12c3f808a733b5c0b258d9e51a5008e9 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13243)
* bdf960d7a22544a0da5587441f99bd49aa9cca98 UNKNOWN
* 058d52ea7c48c665acdd2c124ca356bcfa5599f7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1286870904
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
}, {
"hash" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebfa72e9e43bff234293441c3911e38ab1eb8adc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125)
* adf6a273f5467484ad7be46982d330f1b2b3a169 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1274629959
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebfa72e9e43bff234293441c3911e38ab1eb8adc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1286877606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
}, {
"hash" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423",
"triggerID" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebfa72e9e43bff234293441c3911e38ab1eb8adc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125)
* adf6a273f5467484ad7be46982d330f1b2b3a169 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] voonhous commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
voonhous commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1327390526
@danny0405 Added the required tests to validate this fix, can you please to take a look at it again?
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1287053870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
}, {
"hash" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423",
"triggerID" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* adf6a273f5467484ad7be46982d330f1b2b3a169 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1328016764
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
}, {
"hash" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423",
"triggerID" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"triggerType" : "PUSH"
}, {
"hash" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13243",
"triggerID" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"triggerType" : "PUSH"
}, {
"hash" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"triggerType" : "PUSH"
}, {
"hash" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13245",
"triggerID" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"triggerType" : "PUSH"
}, {
"hash" : "c9060e7436ede0d2e719beeca8bbcd2dad147525",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13253",
"triggerID" : "c9060e7436ede0d2e719beeca8bbcd2dad147525",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdf960d7a22544a0da5587441f99bd49aa9cca98 UNKNOWN
* 058d52ea7c48c665acdd2c124ca356bcfa5599f7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13245)
* c9060e7436ede0d2e719beeca8bbcd2dad147525 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13253)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1327650724
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
}, {
"hash" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423",
"triggerID" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"triggerType" : "PUSH"
}, {
"hash" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13243",
"triggerID" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"triggerType" : "PUSH"
}, {
"hash" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"triggerType" : "PUSH"
}, {
"hash" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13245",
"triggerID" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdf960d7a22544a0da5587441f99bd49aa9cca98 UNKNOWN
* 058d52ea7c48c665acdd2c124ca356bcfa5599f7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13245)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1328037834
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
}, {
"hash" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423",
"triggerID" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"triggerType" : "PUSH"
}, {
"hash" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13243",
"triggerID" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"triggerType" : "PUSH"
}, {
"hash" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"triggerType" : "PUSH"
}, {
"hash" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13245",
"triggerID" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"triggerType" : "PUSH"
}, {
"hash" : "c9060e7436ede0d2e719beeca8bbcd2dad147525",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13253",
"triggerID" : "c9060e7436ede0d2e719beeca8bbcd2dad147525",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdf960d7a22544a0da5587441f99bd49aa9cca98 UNKNOWN
* c9060e7436ede0d2e719beeca8bbcd2dad147525 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13253)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] voonhous commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
voonhous commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1328738415
@danny0405 Added the changes that you have suggested. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1274241135
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebfa72e9e43bff234293441c3911e38ab1eb8adc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1274233386
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebfa72e9e43bff234293441c3911e38ab1eb8adc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] voonhous commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
voonhous commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1286849062
> Can you also add a test class in `TestInputFormat` and test the input splits logic for streaming read in this case ?
>
> You can take a reference from `TestInputFormat#testReadSkipCompaction`
Apologies for the late reply, given that the read behaviour is correct, the only way we can test this fix is to make the `IncrementalInputSplits#getInstantRange` method public.
Since this bug is caused by `IncrementalInputSplits#getInstantRange` not producing the correct result.
I am not sure if loading the class in via reflection is the right way to approach writing this test.
Do you have any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1327470840
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
}, {
"hash" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423",
"triggerID" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"triggerType" : "PUSH"
}, {
"hash" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13243",
"triggerID" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"triggerType" : "PUSH"
}, {
"hash" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"triggerType" : "PUSH"
}, {
"hash" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13245",
"triggerID" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 907782ea12c3f808a733b5c0b258d9e51a5008e9 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13243)
* bdf960d7a22544a0da5587441f99bd49aa9cca98 UNKNOWN
* 058d52ea7c48c665acdd2c124ca356bcfa5599f7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13245)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1330038769
The failed test case in module hudi-utilities should not be affected by this patch, would merge it soon ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #6920:
URL: https://github.com/apache/hudi/pull/6920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1327392125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
}, {
"hash" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423",
"triggerID" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"triggerType" : "PUSH"
}, {
"hash" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13243",
"triggerID" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"triggerType" : "PUSH"
}, {
"hash" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* adf6a273f5467484ad7be46982d330f1b2b3a169 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423)
* 907782ea12c3f808a733b5c0b258d9e51a5008e9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13243)
* bdf960d7a22544a0da5587441f99bd49aa9cca98 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1328710925
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
}, {
"hash" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423",
"triggerID" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"triggerType" : "PUSH"
}, {
"hash" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13243",
"triggerID" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"triggerType" : "PUSH"
}, {
"hash" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"triggerType" : "PUSH"
}, {
"hash" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13245",
"triggerID" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"triggerType" : "PUSH"
}, {
"hash" : "c9060e7436ede0d2e719beeca8bbcd2dad147525",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13253",
"triggerID" : "c9060e7436ede0d2e719beeca8bbcd2dad147525",
"triggerType" : "PUSH"
}, {
"hash" : "fcf16d5a28aa5e128b426885b34cc4e78dd3d5d8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13273",
"triggerID" : "fcf16d5a28aa5e128b426885b34cc4e78dd3d5d8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdf960d7a22544a0da5587441f99bd49aa9cca98 UNKNOWN
* c9060e7436ede0d2e719beeca8bbcd2dad147525 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13253)
* fcf16d5a28aa5e128b426885b34cc4e78dd3d5d8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13273)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1278562873
Nice catch, i have reviewed and applied a patch here:
[5007.patch.zip](https://github.com/apache/hudi/files/9783211/5007.patch.zip)
Can you also add a test class `TestIncrementalInputSplits` and test the input splits logic for streaming read in this case ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #6920:
URL: https://github.com/apache/hudi/pull/6920#discussion_r1033156608
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/source/TestIncrementalInputSplits.java:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.source;
+
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.testutils.HoodieCommonTestHarness;
+import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.utils.TestConfigurations;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.core.fs.Path;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertIterableEquals;
+
Review Comment:
Add doc
```java
Test cases for {@link IncrementalInputSplits}.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] voonhous commented on a diff in pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
voonhous commented on code in PR #6920:
URL: https://github.com/apache/hudi/pull/6920#discussion_r1033191947
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/source/TestIncrementalInputSplits.java:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.source;
+
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.timeline.HoodieTimeline;
+import org.apache.hudi.common.testutils.HoodieCommonTestHarness;
+import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.utils.TestConfigurations;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.core.fs.Path;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertIterableEquals;
+
Review Comment:
Done
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -474,7 +474,7 @@ private HoodieTimeline getArchivedReadTimeline(HoodieTableMetaClient metaClient,
* @param issuedInstant The last issued instant that has already been delivered to downstream
* @return the filtered hoodie instants
*/
- private List<HoodieInstant> filterInstantsWithRange(
+ public List<HoodieInstant> filterInstantsWithRange(
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1328647566
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
}, {
"hash" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423",
"triggerID" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"triggerType" : "PUSH"
}, {
"hash" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13243",
"triggerID" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"triggerType" : "PUSH"
}, {
"hash" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"triggerType" : "PUSH"
}, {
"hash" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13245",
"triggerID" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"triggerType" : "PUSH"
}, {
"hash" : "c9060e7436ede0d2e719beeca8bbcd2dad147525",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13253",
"triggerID" : "c9060e7436ede0d2e719beeca8bbcd2dad147525",
"triggerType" : "PUSH"
}, {
"hash" : "fcf16d5a28aa5e128b426885b34cc4e78dd3d5d8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fcf16d5a28aa5e128b426885b34cc4e78dd3d5d8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdf960d7a22544a0da5587441f99bd49aa9cca98 UNKNOWN
* c9060e7436ede0d2e719beeca8bbcd2dad147525 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13253)
* fcf16d5a28aa5e128b426885b34cc4e78dd3d5d8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1327386944
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
}, {
"hash" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423",
"triggerID" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"triggerType" : "PUSH"
}, {
"hash" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* adf6a273f5467484ad7be46982d330f1b2b3a169 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423)
* 907782ea12c3f808a733b5c0b258d9e51a5008e9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6920: [HUDI-5007] Prevent Hudi from reading the entire timeline's when perf…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6920:
URL: https://github.com/apache/hudi/pull/6920#issuecomment-1328917034
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12125",
"triggerID" : "ebfa72e9e43bff234293441c3911e38ab1eb8adc",
"triggerType" : "PUSH"
}, {
"hash" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12423",
"triggerID" : "adf6a273f5467484ad7be46982d330f1b2b3a169",
"triggerType" : "PUSH"
}, {
"hash" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13243",
"triggerID" : "907782ea12c3f808a733b5c0b258d9e51a5008e9",
"triggerType" : "PUSH"
}, {
"hash" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdf960d7a22544a0da5587441f99bd49aa9cca98",
"triggerType" : "PUSH"
}, {
"hash" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13245",
"triggerID" : "058d52ea7c48c665acdd2c124ca356bcfa5599f7",
"triggerType" : "PUSH"
}, {
"hash" : "c9060e7436ede0d2e719beeca8bbcd2dad147525",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13253",
"triggerID" : "c9060e7436ede0d2e719beeca8bbcd2dad147525",
"triggerType" : "PUSH"
}, {
"hash" : "fcf16d5a28aa5e128b426885b34cc4e78dd3d5d8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13273",
"triggerID" : "fcf16d5a28aa5e128b426885b34cc4e78dd3d5d8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdf960d7a22544a0da5587441f99bd49aa9cca98 UNKNOWN
* fcf16d5a28aa5e128b426885b34cc4e78dd3d5d8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13273)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org