You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/05 13:52:31 UTC
[GitHub] [incubator-nuttx] patacongo opened a new issue #438:
drivers/video/isx012.c: Make forbidden calls into CXD56xx code
patacongo opened a new issue #438: drivers/video/isx012.c: Make forbidden calls into CXD56xx code
URL: https://github.com/apache/incubator-nuttx/issues/438
Common drivers must never call directly in architecture specific code. That is FORBIDDEN.
The driver at drivers/video/isx012.c does just that:
$ grep cxd56 drivers/video/isx012.c
ret = cxd56_cisifinit();
imagererr("Fail cxd56_cisifinit %d\n", ret);
ret = cxd56_cisifstopcapture();
imagererr("Fail cxd56_cisifstopcapture %d\n", ret);
ret = cxd56_cisiffinalize();
imagererr("Fail cxd56_cisiffinalize %d\n", ret);
ret = cxd56_cisifsetdmabuf(&sarea);
ret = cxd56_cisifstartcapture(&cis_param, &sarea);
ret = cxd56_cisifstopcapture();
That is in complete violation of the requirements of the NuttX modular design. This driver must either be corrected so that it uses a standard upper/lower half design as all other drivers do, or it must be removed, or it must be moved to boards/arm/cxd56xx/drivers/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #438:
drivers/video/isx012.c: Make forbidden calls into CXD56xx code
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed issue #438: drivers/video/isx012.c: Make forbidden calls into CXD56xx code
URL: https://github.com/apache/incubator-nuttx/issues/438
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #438:
drivers/video/isx012.c: Make forbidden calls into CXD56xx code
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #438: drivers/video/isx012.c: Make forbidden calls into CXD56xx code
URL: https://github.com/apache/incubator-nuttx/issues/438#issuecomment-595243736
I am looking into it ASAP
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #438:
drivers/video/isx012.c: Make forbidden calls into CXD56xx code
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #438: drivers/video/isx012.c: Make forbidden calls into CXD56xx code
URL: https://github.com/apache/incubator-nuttx/issues/438#issuecomment-595245383
This was reported to me in a personal email from the same person that reported Issue #439.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services