You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/10/31 12:39:04 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #10034:
[FLINK-14400] Shrink scope of MemoryManager from TaskExecutor to slot
azagrebin commented on a change in pull request #10034: [FLINK-14400] Shrink scope of MemoryManager from TaskExecutor to slot
URL: https://github.com/apache/flink/pull/10034#discussion_r341112720
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java
##########
@@ -604,7 +582,7 @@ public int computeNumberOfPages(double fraction) {
}
//noinspection NumericCastThatLosesPrecision
- return (int) (budgetByType.maxTotalNumberOfPages() * fraction / numberOfSlots);
Review comment:
as it was supposed to be the last commit :), at this point `numberOfSlots` can be only 1, so it is needed anymore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services