Re: Review Request 73668: RANGER-3475: added public REST API endpoint to import tags

[Madhan Neethiraj <ma...@apache.org>]

> On Oct. 26, 2021, 11:36 p.m., Abhay Kulkarni wrote:
> > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java
> > Lines 526 (patched)
> > <https://reviews.apache.org/r/73668/diff/2/?file=2254342#file2254342line526>
> >
> >     Please update the documentation for PublicAPIsv2 to include semantics of this new REST API.(Also for line 550)

Documentation update will be handled in a separate patch. I will file a JIRA to track doc pdate.


- Madhan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73668/#review223672
-----------------------------------------------------------


On Nov. 3, 2021, 3 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73668/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2021, 3 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3475
>     https://issues.apache.org/jira/browse/RANGER-3475
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> added a public REST API endpoint service/public/v2/api/service/importtags to import tags into Ranger. This is a wrapper over existing internal API TagREST.importServiceTags().
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceTags.java PRE-CREATION 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceTags.java 9e8e0cf6c 
>   intg/src/main/java/org/apache/ranger/RangerClient.java a1e1c7a7e 
>   intg/src/main/python/apache_ranger/client/ranger_client.py 9f3a6e076 
>   intg/src/main/python/apache_ranger/model/ranger_service_resource.py PRE-CREATION 
>   intg/src/main/python/apache_ranger/model/ranger_service_tags.py PRE-CREATION 
>   intg/src/main/python/apache_ranger/model/ranger_tag.py PRE-CREATION 
>   intg/src/main/python/apache_ranger/model/ranger_tagdef.py PRE-CREATION 
>   ranger-examples/sample-client/src/main/python/sample_client.py 902734901 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 6ab3d52a0 
> 
> 
> Diff: https://reviews.apache.org/r/73668/diff/2/
> 
> 
> Testing
> -------
> 
> - verified adding tags to Ranger via the new API
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>