[jira] [Comment Edited] (MYFACES-3797) cdi support for converters and validators

["Gerhard Petracek (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-3797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788008#comment-13788008 ] 

Gerhard Petracek edited comment on MYFACES-3797 at 10/7/13 9:28 AM:
--------------------------------------------------------------------

#1
the patch doesn't override DeltaStateHelper 

#2
"converter/validator is marked as Serializable":
that isn't an issue - in case of normal-scoped beans only the cdi-proxy (which is serializable) will be stored -> the cdi-container will handle the rest.
in case of serializable dependent scoped beans, we need a 2nd DependentBeanStorage which is session-scoped or even better view-scoped (it isn't part of the first draft, because the last test of the view-scope impl of mf-core showed some issues).

#3
"converter/validator is StateHolder/PartialStateHolder"
see UIComponentBase - that's tested already

#4
"@SessionScope beans"
@SessionScope is a normal-scope in cdi -> we don't have to handle it. the cdi-container will do it. we only see a cdi-proxy for it (which is serializable).


was (Author: gpetracek):
#1
the patch doesn't override DeltaStateHelper 

#2
"converter/validator is marked as Serializable":
that isn't an issue - in case of normal-scoped beans only the cdi-proxy (which is serializable) will be stored -> the cdi-container will handle the rest.
in case of serializable dependent scoped beans, we need a 2nd DependentBeanStorage which is session-scoped (not part of the first-draft).

#3
"converter/validator is StateHolder/PartialStateHolder"
see UIComponentBase - that's tested already

#4
"@SessionScope beans"
@SessionScope is a normal-scope in cdi -> we don't have to handle it. the cdi-container will do it. we only see a cdi-proxy for it (which is serializable).

> cdi support for converters and validators
> -----------------------------------------
>
>                 Key: MYFACES-3797
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3797
>             Project: MyFaces Core
>          Issue Type: New Feature
>          Components: JSR-344
>            Reporter: Gerhard Petracek
>            Assignee: Gerhard Petracek
>         Attachments: MYFACES-3797.patch
>
>
> with
>     <context-param>
>         <param-name>org.apache.myfaces.CONVERTER_INJECTION_ENABLED</param-name>
>         <param-value>true</param-value>
>     </context-param>
> and
>     <context-param>
>         <param-name>org.apache.myfaces.VALIDATOR_INJECTION_ENABLED</param-name>
>         <param-value>true</param-value>
>     </context-param>
> it should be possible to enable cdi support for converters/validators.
> we need the config, because it was postponed for the spec.



--
This message was sent by Atlassian JIRA
(v6.1#6144)