You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2024/10/17 07:55:58 UTC
[PR] Revert "Fix flaky `test_get_dags` in FastAPI routes" [airflow]
pierrejeambrun opened a new pull request, #43108:
URL: https://github.com/apache/airflow/pull/43108
Reverts apache/airflow#43100
This should be reverted because:
- Order actually matters, especially when we are testing `order_by` query parameters. (The returned items must follow the queried order)
- This is not specific to the `get_dags` endpoints but any endpoint returning a list, because the database natural order is not guarantee. (based on insertion etc, etc,)
A fix is already opened here https://github.com/apache/airflow/pull/43085. It was there but got removed by mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Fix flaky `test_get_dags` in FastAPI routes" [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #43108:
URL: https://github.com/apache/airflow/pull/43108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Fix flaky `test_get_dags` in FastAPI routes" [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43108:
URL: https://github.com/apache/airflow/pull/43108#issuecomment-2420051612
Damn...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Fix flaky `test_get_dags` in FastAPI routes" [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #43108:
URL: https://github.com/apache/airflow/pull/43108#issuecomment-2419106405
Damn -- missed the order_by's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org