Re: [PR] CASSANDRASC-115 Add FilteringMetricRegistry to allow filtering of metrics [cassandra-sidecar]

["yifan-c (via GitHub)" <gi...@apache.org>]

yifan-c commented on code in PR #109:
URL: https://github.com/apache/cassandra-sidecar/pull/109#discussion_r1556206283


##########
src/main/dist/conf/sidecar.yaml:
##########
@@ -150,6 +150,12 @@ metrics:
     jmx_domain_name: sidecar.vertx.jmx_domain
     monitored_server_route_regexes:                # regex list to match server routes
      - /api/v1/.*
+  include:
+    - type: "regex"                                # other possible value is "equals"

Review Comment:
   other possible ~value~ _type_ is "equals"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org