You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/05/19 14:35:44 UTC
[GitHub] [iceberg] Fokko opened a new issue, #7658: Remove the direct dependency on Apache Commons
Fokko opened a new issue, #7658:
URL: https://github.com/apache/iceberg/issues/7658
### Feature Request / Improvement
See https://github.com/apache/iceberg/pull/5024/files#r896336657
### Query engine
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hrishisd commented on issue #7658: Remove the direct dependency on Apache Commons
Posted by "hrishisd (via GitHub)" <gi...@apache.org>.
hrishisd commented on issue #7658:
URL: https://github.com/apache/iceberg/issues/7658#issuecomment-1555951638
Hi Fokko,
Is the goal of this issue to remove all uses of apache.commons.io?
```java
$rg 'import org.apache.commons'
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/ProcedureInput.java
24:import org.apache.commons.lang3.StringUtils;
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java
31:import org.apache.commons.io.FileUtils;
32:import org.apache.commons.io.filefilter.TrueFileFilter;
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on issue #7658: Remove the direct dependency on Apache Commons
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #7658:
URL: https://github.com/apache/iceberg/issues/7658#issuecomment-1557025595
I looked into it, and apache commons is a direct dependency of Spark, so I'm not sure if we need to remove it from there. At least other places in Iceberg would be a good idea:
```
➜ iceberg git:(fd-positional-deletes) ✗ grep --include \*.java -R "org.apache.commons" .
./nessie/src/test/java/org/apache/iceberg/nessie/TestNessieTable.java:import org.apache.commons.io.FileUtils;
./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`.
./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`.
./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`.
./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`.
./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`.
./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`.
./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`.
./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * This code is borrowed from `org.apache.commons:commons-lang3`.
./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`.
./aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalController.java:import org.apache.commons.io.input.BoundedInputStream;
./aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalStore.java:import org.apache.commons.io.FileUtils;
./aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockRule.java:import org.apache.commons.io.FileUtils;
./flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java:import org.apache.commons.collections.ListUtils;
./flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/actions/TestRewriteDataFilesAction.java:import org.apache.commons.lang3.StringUtils;
./flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java:import org.apache.commons.collections.ListUtils;
./flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/actions/TestRewriteDataFilesAction.java:import org.apache.commons.lang3.StringUtils;
./flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java:import org.apache.commons.collections.ListUtils;
./flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/actions/TestRewriteDataFilesAction.java:import org.apache.commons.lang3.StringUtils;
./delta-lake/src/integration/java/org/apache/iceberg/delta/TestSnapshotDeltaLakeTable.java:import org.apache.commons.codec.DecoderException;
./delta-lake/src/integration/java/org/apache/iceberg/delta/TestSnapshotDeltaLakeTable.java:import org.apache.commons.codec.net.URLCodec;
./delta-lake/src/main/java/org/apache/iceberg/delta/BaseSnapshotDeltaLakeTableAction.java:import org.apache.commons.codec.DecoderException;
./delta-lake/src/main/java/org/apache/iceberg/delta/BaseSnapshotDeltaLakeTableAction.java:import org.apache.commons.codec.net.URLCodec;
./hive3/src/main/java/org/apache/iceberg/mr/hive/vector/HiveVectorizedReader.java:import org.apache.commons.lang3.ArrayUtils;
./hive3/src/main/java/org/apache/iceberg/mr/hive/vector/CompatibilityHiveVectorUtils.java:import org.apache.commons.lang3.StringUtils;
./gcp/src/test/java/org/apache/iceberg/gcp/gcs/GCSInputStreamTest.java:import org.apache.commons.io.IOUtils;
./gcp/src/test/java/org/apache/iceberg/gcp/gcs/GCSFileIOTest.java:import org.apache.commons.io.IOUtils;
./dell/src/test/java/org/apache/iceberg/dell/mock/ecs/ObjectData.java:import com.emc.object.shadow.org.apache.commons.codec.digest.DigestUtils;
./aws/src/test/java/org/apache/iceberg/aws/s3/TestS3InputStream.java:import org.apache.commons.io.IOUtils;
./aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:import org.apache.commons.io.IOUtils;
./aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:import org.apache.commons.lang3.SerializationUtils;
./aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java:import org.apache.commons.lang3.SerializationUtils;
./parquet/src/main/java/org/apache/iceberg/parquet/ParquetAvro.java:import org.apache.commons.math3.util.Pair;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra closed issue #7658: Remove the direct dependency on Apache Commons
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra closed issue #7658: Remove the direct dependency on Apache Commons
URL: https://github.com/apache/iceberg/issues/7658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] anki7t commented on issue #7658: Remove the direct dependency on Apache Commons
Posted by "anki7t (via GitHub)" <gi...@apache.org>.
anki7t commented on issue #7658:
URL: https://github.com/apache/iceberg/issues/7658#issuecomment-1557694904
@Fokko yes it is a dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] anki7t commented on issue #7658: Remove the direct dependency on Apache Commons
Posted by "anki7t (via GitHub)" <gi...@apache.org>.
anki7t commented on issue #7658:
URL: https://github.com/apache/iceberg/issues/7658#issuecomment-1556108662
Hi @Fokko ,
is this issue solution already merged? if not, i can work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Neuw84 commented on issue #7658: Remove the direct dependency on Apache Commons
Posted by "Neuw84 (via GitHub)" <gi...@apache.org>.
Neuw84 commented on issue #7658:
URL: https://github.com/apache/iceberg/issues/7658#issuecomment-1621216325
Hi,
I had some spare time and wanted to start contributing. I have cleaned the dependency on those projects that make sense ( Spark & Flink declare it as direct dependency).
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org