You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/12/01 13:01:20 UTC
[GitHub] [lucene] luyuncheng commented on pull request #11987: Make Decompressor release memory buffer
luyuncheng commented on PR #11987:
URL: https://github.com/apache/lucene/pull/11987#issuecomment-1333730146
> We could run the StoredFieldsBenchmark before and after the change with -Dorg.apache.lucene.codecs.lucene90.compressing.Lucene90CompressingStoredFieldsWriter.enableBulkMerge=false to force the slow merge path.
> In all cases when running the benchmark, we may want to explicitly supply smaller heap (-Xmx),
@rmuir I just modified https://github.com/mikemccand/luceneutil/blob/master/src/python/runStoredFieldsBenchmark.py#L43 with
`command = f'{localconstants.JAVA_EXE} -Xmx256m -Dorg.apache.lucene.codecs.lucene90.compressing.Lucene90CompressingStoredFieldsWriter.enableBulkMerge=false -cp {lucene_core_jar}:build perf.StoredFieldsBenchmark {geoname s_csv_in} {localconstants.INDEX_DIR_BASE}/geonames-stored-fields {mode} {doc_limit}`
i do 4 different runStoredFieldsBenchmark as following tables shows which shows little performance regressions:
runStoredFieldsBenchmark.py __enableBulkMerge=false__
| | Baseline | Candidate |
| :--- | :----: | ---: |
| indexing_time_msec| | |
| BEST_SPEED | 365665.00 | 372287.00 |
| BEST_COMPRESSION | 849157.00 | 848813.00 |
| retrieved_time_msec | | |
| BEST_SPEED | 246.62 | 269.32 |
| BEST_COMPRESSION | 2606.98 | 2634.53 |
runStoredFieldsBenchmark.py __enableBulkMerge=false -Xmx1g__
| | Baseline | Candidate |
| :--- | :----: | ---: |
| indexing_time_msec | | |
| BEST_SPEED | 372457.00 | 366094.00 |
| BEST_COMPRESSION | 850273.00 | 852397.00 |
| retrieved_time_msec | | |
| BEST_SPEED | 247.70 | 279.11 |
| BEST_COMPRESSION | 2585.59 | 2633.83 |
runStoredFieldsBenchmark.py __enableBulkMerge=false -Xmx512m__
| | Baseline | Candidate |
| :--- | :----: | ---: |
| indexing_time_msec | | |
| BEST_SPEED | 368389.00 | 370878.00 |
| BEST_COMPRESSION | 851277.00 | 850121.00 |
| retrieved_time_msec | | |
| BEST_SPEED | 256.80 | 280.52 |
| BEST_COMPRESSION | 2576.36 | 2645.32 |
runStoredFieldsBenchmark.py __enableBulkMerge=false -Xmx256m__
| | Baseline | Candidate |
| :--- | :----: | ---: |
| indexing_time_msec | | |
| BEST_SPEED | 366735.00 | 368407.00 |
| BEST_COMPRESSION | 849980.00 | 852214.00 |
| retrieved_time_msec | | |
| BEST_SPEED | 256.10 | 278.06 |
| BEST_COMPRESSION | 2584.96 | 2632.69 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org