[GitHub] [spark] MaxGekk commented on a change in pull request #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #27980: [WIP][SQL] Rebase any date-times in conversions to/from Java types
URL: https://github.com/apache/spark/pull/27980#discussion_r396128163
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
 ##########
 @@ -508,8 +504,8 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
       test("2016-03-13 03:00:00", "PST", "2016-03-13 10:00:00.0")
       test("2016-11-06 00:59:59", "PST", "2016-11-06 07:59:59.0")
       // 2016-11-06 01:00:00 PST could be 2016-11-06 08:00:00 UTC or 2016-11-06 09:00:00 UTC
-      test("2016-11-06 01:00:00", "PST", "2016-11-06 09:00:00.0")
-      test("2016-11-06 01:59:59", "PST", "2016-11-06 09:59:59.0")
+      test("2016-11-06 01:00:00", "PST", "2016-11-06 08:00:00.0")
 
 Review comment:
   See the comment above. `08` or `09` depends on the implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org