You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by PSUdaemon <gi...@git.apache.org> on 2016/11/22 21:59:37 UTC

[GitHub] trafficserver pull request #1231: TS-4720 back port

GitHub user PSUdaemon opened a pull request:

    https://github.com/apache/trafficserver/pull/1231

    TS-4720 back port

    HttpTransact defaults content length to `-1`, meaning that if the request has no content length header it will be `-1`. These checks weren't taking that into consideration -- meaning client aborts during requests with no content length (GET for example) would leave the origin session open until another timeout kicked in.
    
    (cherry picked from commit a075556602d77d79f5a02e2a36053abfa92703f0)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PSUdaemon/trafficserver ts-4720-cp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1231.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1231
    
----
commit a17b851427696aa40b3ade46d66a1235f6bef9f9
Author: Thomas Jackson <ja...@gmail.com>
Date:   2016-08-05T00:55:59Z

    TS-4720 correctly check if requests have a body
    
    HttpTransact defaults content length to `-1`, meaning that if the request has no content length header it will be `-1`. These checks weren't taking that into consideration -- meaning client aborts during requests with no content length (GET for example) would leave the origin session open until another timeout kicked in.
    
    (cherry picked from commit a075556602d77d79f5a02e2a36053abfa92703f0)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1231: TS-4720 back port

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1231
  
    FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1210/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1231: TS-4720 back port

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1231
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1103/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1231: TS-4720 back port

Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon closed the pull request at:

    https://github.com/apache/trafficserver/pull/1231


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---