You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/31 13:16:24 UTC
[GitHub] TisonKun commented on a change in pull request #6634:
[FLINK-10208][build] Bump mockito to 2.21.0 / powermock to 2.0.0-beta.5
TisonKun commented on a change in pull request #6634: [FLINK-10208][build] Bump mockito to 2.21.0 / powermock to 2.0.0-beta.5
URL: https://github.com/apache/flink/pull/6634#discussion_r214349501
##########
File path: flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendSavepointTest.java
##########
@@ -315,7 +315,7 @@ private static void restoreStdOutAndStdErr() {
private static ClusterClient<String> createClusterClient(String expectedResponse) throws Exception {
final ClusterClient<String> clusterClient = mock(ClusterClient.class);
- when(clusterClient.triggerSavepoint(any(JobID.class), anyString()))
+ when(clusterClient.triggerSavepoint(any(JobID.class), nullable(String.class)))
Review comment:
@zentol What is the preference between `nullable(<any>)` and `any(<class>)`? Inconsistent on this, take a look at `HadoopOutputFormatTest.java` where change `any(FileSystem.class)` to `nullable(FileSystem.class)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services