You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/10 19:57:59 UTC
[GitHub] [spark] kazuyukitanimura opened a new pull request #35156: [SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2
kazuyukitanimura opened a new pull request #35156:
URL: https://github.com/apache/spark/pull/35156
### What changes were proposed in this pull request?
This PR proposes to improve `DataSourceV2Strategy` to be able to push down boolean column filters. Currently boolean column filters do not get pushed down and may cause unnecessary IO.
This is a follow up PR of the same change for (V1) `DataSourceStrategy`.
### Why are the changes needed?
The following query does not push down the filter in the current implementation
```
SELECT * FROM t WHERE boolean_field
```
although the following query pushes down the filter as expected.
```
SELECT * FROM t WHERE boolean_field = true
```
This is because the Physical Planner (`DataSourceV2Strategy`) currently only pushes down limited expression patterns like`EqualTo`.
It is fair for Spark SQL users to expect `boolean_field` performs the same as `boolean_field = true`.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Added unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #35156: [SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #35156:
URL: https://github.com/apache/spark/pull/35156#discussion_r782529210
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2StrategySuite.scala
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import org.apache.spark.sql.catalyst.dsl.expressions._
+import org.apache.spark.sql.catalyst.expressions.Expression
+import org.apache.spark.sql.catalyst.plans.PlanTest
+import org.apache.spark.sql.connector.expressions.{FieldReference, LiteralValue}
+import org.apache.spark.sql.connector.expressions.filter.{EqualTo => V2EqualTo, Filter => V2Filter}
+import org.apache.spark.sql.test.SharedSparkSession
+import org.apache.spark.sql.types.BooleanType
+
+class DataSourceV2StrategySuite extends PlanTest with SharedSparkSession {
+ test("SPARK-36644: Push down boolean column filter") {
+ testTranslateFilter('col.boolean,
+ Some(new V2EqualTo(FieldReference("col"), LiteralValue(true, BooleanType))))
+ }
+
+ /**
+ * Translate the given Catalyst [[Expression]] into data source [[V2Filter]]
+ * then verify against the given [[V2Filter]].
+ */
+ def testTranslateFilter(catalystFilter: Expression, result: Option[V2Filter]): Unit = {
+ assertResult(result) {
+ DataSourceV2Strategy.translateFilterV2(catalystFilter, true)
Review comment:
I haven't finished the `V2Filter` migration yet. Right now I have provided a new interface `SupportsPushDownV2Filters` for data source to implement, but I haven't changed any of the code paths in v2 file source or JDBC to use `V2Filter` yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kazuyukitanimura commented on pull request #35156: [SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2
Posted by GitBox <gi...@apache.org>.
kazuyukitanimura commented on pull request #35156:
URL: https://github.com/apache/spark/pull/35156#issuecomment-1009292731
cc @sunchao @viirya @huaxingao @HyukjinKwon @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #35156: [SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #35156:
URL: https://github.com/apache/spark/pull/35156#issuecomment-1009598053
+1 to @huaxingao 's suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao closed pull request #35156: [SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2
Posted by GitBox <gi...@apache.org>.
sunchao closed pull request #35156:
URL: https://github.com/apache/spark/pull/35156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kazuyukitanimura commented on a change in pull request #35156: [SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2
Posted by GitBox <gi...@apache.org>.
kazuyukitanimura commented on a change in pull request #35156:
URL: https://github.com/apache/spark/pull/35156#discussion_r782496644
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2StrategySuite.scala
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import org.apache.spark.sql.catalyst.dsl.expressions._
+import org.apache.spark.sql.catalyst.expressions.Expression
+import org.apache.spark.sql.catalyst.plans.PlanTest
+import org.apache.spark.sql.connector.expressions.{FieldReference, LiteralValue}
+import org.apache.spark.sql.connector.expressions.filter.{EqualTo => V2EqualTo, Filter => V2Filter}
+import org.apache.spark.sql.test.SharedSparkSession
+import org.apache.spark.sql.types.BooleanType
+
+class DataSourceV2StrategySuite extends PlanTest with SharedSparkSession {
+ test("SPARK-36644: Push down boolean column filter") {
+ testTranslateFilter('col.boolean,
+ Some(new V2EqualTo(FieldReference("col"), LiteralValue(true, BooleanType))))
+ }
+
+ /**
+ * Translate the given Catalyst [[Expression]] into data source [[V2Filter]]
+ * then verify against the given [[V2Filter]].
+ */
+ def testTranslateFilter(catalystFilter: Expression, result: Option[V2Filter]): Unit = {
+ assertResult(result) {
+ DataSourceV2Strategy.translateFilterV2(catalystFilter, true)
Review comment:
`DataSourceV2Strategy.translateFilterV2` is not currently called; however the V1 version (`DataSourceStrategy.translateFilter`) is used within V2 code. We can plan to migrate those to use `DataSourceV2Strategy.translateFilterV2` in the next PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kazuyukitanimura commented on a change in pull request #35156: [SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2
Posted by GitBox <gi...@apache.org>.
kazuyukitanimura commented on a change in pull request #35156:
URL: https://github.com/apache/spark/pull/35156#discussion_r782544356
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2StrategySuite.scala
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import org.apache.spark.sql.catalyst.dsl.expressions._
+import org.apache.spark.sql.catalyst.expressions.Expression
+import org.apache.spark.sql.catalyst.plans.PlanTest
+import org.apache.spark.sql.connector.expressions.{FieldReference, LiteralValue}
+import org.apache.spark.sql.connector.expressions.filter.{EqualTo => V2EqualTo, Filter => V2Filter}
+import org.apache.spark.sql.test.SharedSparkSession
+import org.apache.spark.sql.types.BooleanType
+
+class DataSourceV2StrategySuite extends PlanTest with SharedSparkSession {
+ test("SPARK-36644: Push down boolean column filter") {
+ testTranslateFilter('col.boolean,
+ Some(new V2EqualTo(FieldReference("col"), LiteralValue(true, BooleanType))))
+ }
+
+ /**
+ * Translate the given Catalyst [[Expression]] into data source [[V2Filter]]
+ * then verify against the given [[V2Filter]].
+ */
+ def testTranslateFilter(catalystFilter: Expression, result: Option[V2Filter]): Unit = {
+ assertResult(result) {
+ DataSourceV2Strategy.translateFilterV2(catalystFilter, true)
Review comment:
Thank you @huaxingao for the explanation. Since I touched this area, I will try to contribute in the migration as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #35156: [SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #35156:
URL: https://github.com/apache/spark/pull/35156#issuecomment-1009579698
@kazuyukitanimura Thanks for working on this! Overall the PR looks good to me. I am just thinking the newly added test `DataSourceV2StrategySuite` is sufficient for the change. It seems to me that we only need to test if the boolean column filter can be translated correctly, but we don't have to add a new test in `DataSourceV2Suite` to check if the boolean column filter can be pushed down. If a filter can be translated correctly, it should be pushed down for sure. That path has been very well tested, so I guess we can keep the test simple :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kazuyukitanimura commented on pull request #35156: [SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2
Posted by GitBox <gi...@apache.org>.
kazuyukitanimura commented on pull request #35156:
URL: https://github.com/apache/spark/pull/35156#issuecomment-1010356890
Thank you @sunchao @viirya
Since what we are testing is within `DataSourceV2Strategy`, I think `DataSourceV2StrategySuite` name makes sense.
In addition, We have a counter part of V1 for this, `DataSourceStrategy` and `DataSourceStrategySuite`, so it is consistent.
I can plan to add more tests in `DataSourceV2StrategySuite` for other expressions (e.g. GreaterThan...) in the future.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kazuyukitanimura commented on pull request #35156: [SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2
Posted by GitBox <gi...@apache.org>.
kazuyukitanimura commented on pull request #35156:
URL: https://github.com/apache/spark/pull/35156#issuecomment-1009598792
Thank you @huaxingao @cloud-fan, removed the changes in `DataSourceV2Suite`. Please have another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #35156: [SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #35156:
URL: https://github.com/apache/spark/pull/35156#discussion_r781789654
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2StrategySuite.scala
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import org.apache.spark.sql.catalyst.dsl.expressions._
+import org.apache.spark.sql.catalyst.expressions.Expression
+import org.apache.spark.sql.catalyst.plans.PlanTest
+import org.apache.spark.sql.connector.expressions.{FieldReference, LiteralValue}
+import org.apache.spark.sql.connector.expressions.filter.{EqualTo => V2EqualTo, Filter => V2Filter}
+import org.apache.spark.sql.test.SharedSparkSession
+import org.apache.spark.sql.types.BooleanType
+
+class DataSourceV2StrategySuite extends PlanTest with SharedSparkSession {
+ test("SPARK-36644: Push down boolean column filter") {
+ testTranslateFilter('col.boolean,
+ Some(new V2EqualTo(FieldReference("col"), LiteralValue(true, BooleanType))))
+ }
+
+ /**
+ * Translate the given Catalyst [[Expression]] into data source [[V2Filter]]
+ * then verify against the given [[V2Filter]].
+ */
+ def testTranslateFilter(catalystFilter: Expression, result: Option[V2Filter]): Unit = {
+ assertResult(result) {
+ DataSourceV2Strategy.translateFilterV2(catalystFilter, true)
Review comment:
Is `DataSourceV2Strategy.translateFilterV2` being used in anywhere? I couldn't find any callers of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35156: [SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35156:
URL: https://github.com/apache/spark/pull/35156#discussion_r781814485
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2StrategySuite.scala
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import org.apache.spark.sql.catalyst.dsl.expressions._
+import org.apache.spark.sql.catalyst.expressions.Expression
+import org.apache.spark.sql.catalyst.plans.PlanTest
+import org.apache.spark.sql.connector.expressions.{FieldReference, LiteralValue}
+import org.apache.spark.sql.connector.expressions.filter.{EqualTo => V2EqualTo, Filter => V2Filter}
+import org.apache.spark.sql.test.SharedSparkSession
+import org.apache.spark.sql.types.BooleanType
+
+class DataSourceV2StrategySuite extends PlanTest with SharedSparkSession {
Review comment:
There is `FiltersV2Suite`. Maybe put the test there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kazuyukitanimura commented on a change in pull request #35156: [SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2
Posted by GitBox <gi...@apache.org>.
kazuyukitanimura commented on a change in pull request #35156:
URL: https://github.com/apache/spark/pull/35156#discussion_r782515003
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2StrategySuite.scala
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import org.apache.spark.sql.catalyst.dsl.expressions._
+import org.apache.spark.sql.catalyst.expressions.Expression
+import org.apache.spark.sql.catalyst.plans.PlanTest
+import org.apache.spark.sql.connector.expressions.{FieldReference, LiteralValue}
+import org.apache.spark.sql.connector.expressions.filter.{EqualTo => V2EqualTo, Filter => V2Filter}
+import org.apache.spark.sql.test.SharedSparkSession
+import org.apache.spark.sql.types.BooleanType
+
+class DataSourceV2StrategySuite extends PlanTest with SharedSparkSession {
Review comment:
Thanks. `FiltersV2Suite` seems to be a little different from what we want to test here.
What we need to test is the translation via `translateFilterV2WithMapping`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #35156: [SPARK-36644][SQL][FOLLOWUP] Push down boolean column filter for Data Srouce V2
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #35156:
URL: https://github.com/apache/spark/pull/35156#issuecomment-1010501026
Merged to master, thanks @kazuyukitanimura!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org