You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/03/18 16:32:48 UTC

[GitHub] [cordova-android] apiaget commented on issue #689: Build errors about drawable since upgrading to v8.0.0

apiaget commented on issue #689: Build errors about drawable since upgrading to v8.0.0
URL: https://github.com/apache/cordova-android/issues/689#issuecomment-473992821
 
 
   Hello all !
   
   This error also appears when I do release build after upgrading to cordva-android@8.0.0.
   
   I noticed that the error/warning disappear when I do the following modifications in my config.xml file:
   
   Before (the following rises 4 errors/warning):
   ```
   <platform name="android">
       <edit-config file="AndroidManifest.xml" mode="merge" target="/manifest/application">
           <application android:usesCleartextTraffic="true">
           </application>
       </edit-config>
       <preference name="loadUrlTimeoutValue" value="700000" />
       <icon background="res/icons/android/ldpi-background.png" density="ldpi" foreground="res/icons/android/ldpi-foreground.png" src="res/icons/android/drawable-ldpi-icon.png" />
       <icon background="res/icons/android/mdpi-background.png" density="mdpi" foreground="res/icons/android/mdpi-foreground.png" src="res/icons/android/drawable-mdpi-icon.png" />
       <icon background="res/icons/android/hdpi-background.png" density="hdpi" foreground="res/icons/android/hdpi-foreground.png" src="res/icons/android/drawable-hdpi-icon.png" />
       <icon background="res/icons/android/xhdpi-background.png" density="xhdpi" foreground="res/icons/android/xhdpi-foreground.png" src="res/icons/android/drawable-xhdpi-icon.png" />
       <icon background="res/icons/android/xxhdpi-background.png" density="xxhdpi" foreground="res/icons/android/xxhdpi-foreground.png" src="res/icons/android/drawable-xxhdpi-icon.png" />
       <icon background="res/icons/android/xxxhdpi-background.png" density="xxxhdpi" foreground="res/icons/android/xxxhdpi-foreground.png" src="res/icons/android/drawable-xxxhdpi-icon.png" />
       <splash density="port-hdpi" src="res/screen/android/splash-port-hdpi.png" />
       <splash density="port-ldpi" src="res/screen/android/splash-port-ldpi.png" />
       <splash density="port-mdpi" src="res/screen/android/splash-port-mdpi.png" />
       <splash density="port-xhdpi" src="res/screen/android/splash-port-xhdpi.png" />
   </platform>
   ```
   
   After (the following rises no error/warning):
   
   ```
   <platform name="android">
       <edit-config file="AndroidManifest.xml" mode="merge" target="/manifest/application">
           <application android:usesCleartextTraffic="true">
           </application>
       </edit-config>
       <preference name="loadUrlTimeoutValue" value="700000" />
       <icon background="res/icons/android/ldpi-background.png" density="ldpi" foreground="res/icons/android/ldpi-foreground.png" src="res/icons/android/drawable-ldpi-icon.png" />
       <icon background="res/icons/android/mdpi-background.png" density="mdpi" foreground="res/icons/android/mdpi-foreground.png" src="res/icons/android/drawable-mdpi-icon.png" />
       <icon background="res/icons/android/hdpi-background.png" density="hdpi" foreground="res/icons/android/hdpi-foreground.png" src="res/icons/android/drawable-hdpi-icon.png" />
       <icon background="res/icons/android/xhdpi-background.png" density="xhdpi" foreground="res/icons/android/xhdpi-foreground.png" src="res/icons/android/drawable-xhdpi-icon.png" />
       <icon background="res/icons/android/xxhdpi-background.png" density="xxhdpi" foreground="res/icons/android/xxhdpi-foreground.png" src="res/icons/android/drawable-xxhdpi-icon.png" />
       <icon background="res/icons/android/xxxhdpi-background.png" density="xxxhdpi" foreground="res/icons/android/xxxhdpi-foreground.png" src="res/icons/android/drawable-xxxhdpi-icon.png" />
       <splash density="hdpi" src="res/screen/android/splash-port-hdpi.png" />
       <splash density="port-hdpi" src="res/screen/android/splash-port-hdpi.png" />
       <splash density="ldpi" src="res/screen/android/splash-port-ldpi.png" />
       <splash density="port-ldpi" src="res/screen/android/splash-port-ldpi.png" />
       <splash density="mdpi" src="res/screen/android/splash-port-mdpi.png" />
       <splash density="port-mdpi" src="res/screen/android/splash-port-mdpi.png" />
       <splash density="xhdpi" src="res/screen/android/splash-port-xhdpi.png" />
       <splash density="port-xhdpi" src="res/screen/android/splash-port-xhdpi.png" />
   </platform>
   ```
   
   Do you think that adding the "default" densities is correct to solve this problem (hdpi, ldpi, mdpi and xhdpi in my case) or is the error caused by something else ? In fact I do not really know if I am really solving the problem or just workarounding it...
   
   apiaget

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org