You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org> on 2016/06/21 23:32:16 UTC

[Impala-CR](cdh5-trunk) IMPALA-3698: Fix Isilon permissions test

Taras Bobrovytsky has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3433

Change subject: IMPALA-3698: Fix Isilon permissions test
......................................................................

IMPALA-3698: Fix Isilon permissions test

Isilon OneFS 8.0 introduces a regression where a
ConnectionRefusedException is thrown if the table directory permission
is set to 444. This patch fixes the problem by changing the table
directory permissions to 544 for Isilon in the read only table test.

Change-Id: Ie5ed082133ad3ca35a7f68fa4be118a0e59270b8
---
M tests/metadata/test_hdfs_permissions.py
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/33/3433/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5ed082133ad3ca35a7f68fa4be118a0e59270b8
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3698: Fix Isilon permissions test

Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has submitted this change and it was merged.

Change subject: IMPALA-3698: Fix Isilon permissions test
......................................................................


IMPALA-3698: Fix Isilon permissions test

Isilon OneFS 8.0 introduces a regression where a
ConnectionRefusedException is thrown if the table directory permission
is set to 444. This patch fixes the problem by changing the table
directory permissions to 544 for Isilon in the read only table test.

Change-Id: Ie5ed082133ad3ca35a7f68fa4be118a0e59270b8
Reviewed-on: http://gerrit.cloudera.org:8080/3433
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: Taras Bobrovytsky <tb...@cloudera.com>
---
M tests/metadata/test_hdfs_permissions.py
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  David Knupp: Looks good to me, approved
  Taras Bobrovytsky: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5ed082133ad3ca35a7f68fa4be118a0e59270b8
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3698: Fix Isilon permissions test

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.

Change subject: IMPALA-3698: Fix Isilon permissions test
......................................................................


Patch Set 1: Code-Review+2

Do we typically wait for a successful jenkins verification before giving a +2? I read the bug, and this seems like an innocuous, sane change.

-- 
To view, visit http://gerrit.cloudera.org:8080/3433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5ed082133ad3ca35a7f68fa4be118a0e59270b8
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-3698: Fix Isilon permissions test

Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3698: Fix Isilon permissions test
......................................................................


Patch Set 2:

David, it's not necessary to wait for a successful jenkins verification before giving a +2. We have the gerrit-verify-merge job for that (which is run after a +2 is given).

-- 
To view, visit http://gerrit.cloudera.org:8080/3433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5ed082133ad3ca35a7f68fa4be118a0e59270b8
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-3698: Fix Isilon permissions test

Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3698: Fix Isilon permissions test
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/3433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5ed082133ad3ca35a7f68fa4be118a0e59270b8
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-3698: Fix Isilon permissions test

Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3698: Fix Isilon permissions test
......................................................................


Patch Set 1:

All tests passed in: http://sandbox.jenkins.cloudera.com/job/impala-private-build-and-test/3496/

-- 
To view, visit http://gerrit.cloudera.org:8080/3433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5ed082133ad3ca35a7f68fa4be118a0e59270b8
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No