[GitHub] [trafficserver] shinrich edited a comment on pull request #7285: Race condition between Server session release and Net read

[GitBox <gi...@apache.org>]

shinrich edited a comment on pull request #7285:
URL: https://github.com/apache/trafficserver/pull/7285#issuecomment-713819918


   What are the cases where the server_netvc is doing a read from a different thread?  The server_netvc and the client_netvc and the HttpSM are all associated with the same ET_NET thread for the duration of the HttpSM.  So all the net I/O should be performed in the same ET_NET thread.  In that case the buffer frees in Http1ServerSession::do_io_close are serialized with the READ/WRITE event processing.
   
   In my reading of the current master, we may need to add do_io_read(nullptr, 0, nullptr) and do_io_write(nullptr, 0, nullptr) in the Http1ServerSession::do_io_close to ensure that a later net/io event does not get sent back to the now deleted continuation.  But if the server_vc is still set, the closed flag should already be set which should block any future net/IO on that netvc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org