You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/30 22:24:46 UTC
[GitHub] [pulsar] cbornet opened a new pull request, #15846: [fix][python]Fix generated Python protobuf code not compatible with l…
cbornet opened a new pull request, #15846:
URL: https://github.com/apache/pulsar/pull/15846
…atest protobuf package
### Motivation
Protobuf latest 4.21 version broke compatibility with files generated with protoc < 3.19
As a result all current CI tests fail.
See https://developers.google.com/protocol-buffers/docs/news/2022-05-06
### Modifications
This fix downgrades protobuf python package to 3.20.1.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
no
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
fix
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #15846: [fix][python]Fix generated Python protobuf code not compatible with latest protobuf package
Posted by GitBox <gi...@apache.org>.
zymap commented on PR #15846:
URL: https://github.com/apache/pulsar/pull/15846#issuecomment-1141645106
Make sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #15846: [fix][python]Fix generated Python protobuf code not compatible with latest protobuf package
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #15846:
URL: https://github.com/apache/pulsar/pull/15846#issuecomment-1141639289
> Shouldn't we regenerate the code to support the latest protobuf?
@zymap I suppose you are referring to #15827. That makes sense. However, this PR doesn't conflict with that and there's no reason to block this PR with requesting changes. Let's keep the PRs separate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #15846: [fix][python]Fix generated Python protobuf code not compatible with latest protobuf package
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #15846:
URL: https://github.com/apache/pulsar/pull/15846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #15846: [fix][python]Fix generated Python protobuf code not compatible with latest protobuf package
Posted by GitBox <gi...@apache.org>.
zymap commented on PR #15846:
URL: https://github.com/apache/pulsar/pull/15846#issuecomment-1141729275
Sorry it’s my fault. I wanted to rerun the failed test but accidentally clicked the wrong one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #15846: [fix][python]Fix generated Python protobuf code not compatible with latest protobuf package
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #15846:
URL: https://github.com/apache/pulsar/pull/15846#issuecomment-1141724817
@zymap Why did you restart all tests and not just the failed ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #15846: [fix][python]Fix generated Python protobuf code not compatible with latest protobuf package
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #15846:
URL: https://github.com/apache/pulsar/pull/15846#issuecomment-1141664613
I added another commit to this PR to limit the version to 3.20.* in setup.py for the Pulsar Python client's dependencies. This would be a useful fix also for maintenance branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org