[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #723: MINIFICPP-1140 - Fix VolatileFlowFileRepository

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #723: MINIFICPP-1140 - Fix VolatileFlowFileRepository
URL: https://github.com/apache/nifi-minifi-cpp/pull/723#discussion_r373480930
 
 

 ##########
 File path: libminifi/include/core/repository/VolatileFlowFileRepository.h
 ##########
 @@ -55,7 +55,9 @@ class VolatileFlowFileRepository : public VolatileRepository<std::string> {
           std::shared_ptr<FlowFileRecord> eventRead = std::make_shared<FlowFileRecord>(shared_from_this(), content_repo_);
           if (eventRead->DeSerialize(reinterpret_cast<const uint8_t *>(purgeItem.data()), purgeItem.size())) {
             std::shared_ptr<minifi::ResourceClaim> newClaim = eventRead->getResourceClaim();
-            content_repo_->remove(newClaim);
+            if (newClaim != nullptr) {
+              content_repo_->removeIfOrphaned(newClaim);
 
 Review comment:
   Ouch... 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services