You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 19:17:59 UTC

[GitHub] [arrow] nealrichardson commented on a change in pull request #9118: [WIP] Arrow 10623: [CI][R] Version 1.0.1 breaks data.frame attributes when reading file written by 2.0.0

nealrichardson commented on a change in pull request #9118:
URL: https://github.com/apache/arrow/pull/9118#discussion_r553530478



##########
File path: r/extra-tests/test-read-parquet.R
##########
@@ -0,0 +1,50 @@
+library(arrow)
+library(testthat)
+
+skip_if_version <- function(version, msg, op = `<=`) {

Review comment:
       This `op` is a little non-obvious. I'd rather have explicit skip function names (skip_if_version_equal, skip_if_version_less_than, etc.)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org