You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "genericqa (JIRA)" <ji...@apache.org> on 2018/03/20 21:03:00 UTC
[jira] [Commented] (HDFS-10274) Move
NameSystem#isInStartupSafeMode() to BlockManagerSafeMode
[ https://issues.apache.org/jira/browse/HDFS-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407043#comment-16407043 ]
genericqa commented on HDFS-10274:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color} | {color:red} HDFS-10274 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-10274 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12797856/HDFS-10274-01.patch |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/23590/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Move NameSystem#isInStartupSafeMode() to BlockManagerSafeMode
> -------------------------------------------------------------
>
> Key: HDFS-10274
> URL: https://issues.apache.org/jira/browse/HDFS-10274
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Vinayakumar B
> Assignee: Vinayakumar B
> Priority: Major
> Attachments: HDFS-10274-01.patch
>
>
> To reduce the number of methods in Namesystem interface and for clean looking refactor, its better to move {{isInStartupSafeMode()}} to BlockManager and BlockManagerSafeMode, as most of the callers are in BlockManager. So one more interface overhead can be reduced.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org