You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/03/31 01:40:19 UTC
[GitHub] [skywalking] wankai123 opened a new pull request #8772: Adjust MAL for V9 and update UI template
wankai123 opened a new pull request #8772:
URL: https://github.com/apache/skywalking/pull/8772
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
Add UI template custom folder.
Adjust MAL for V9, remove some groups, add a new Service function for the custom delimiter.
Sync ui.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #8772: Adjust MAL for V9 and update UI template
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #8772:
URL: https://github.com/apache/skywalking/pull/8772#discussion_r839208371
##########
File path: oap-server/server-starter/src/main/resources/otel-oc-rules/k8s-service.yaml
##########
@@ -29,7 +29,7 @@
# "-P-6H+3M" -- parses as "+6 hours and -3 minutes"
# </pre>
filter: "{ tags -> tags.job_name in [ 'kubernetes-cadvisor', 'kube-state-metrics' ] }" # The OpenTelemetry job name
-expSuffix: tag({tags -> tags.cluster = 'k8s-cluster::' + tags.cluster}).endpoint(['cluster'] , ['service'], Layer.K8S)
+expSuffix: service(['cluster' , 'service', 'oo'], '::', Layer.K8S_SERVICE)
Review comment:
my bad,will fix on UI sync
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #8772: Adjust MAL for V9 and update UI template
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #8772:
URL: https://github.com/apache/skywalking/pull/8772#discussion_r839207132
##########
File path: oap-server/server-starter/src/main/resources/otel-oc-rules/k8s-service.yaml
##########
@@ -29,7 +29,7 @@
# "-P-6H+3M" -- parses as "+6 hours and -3 minutes"
# </pre>
filter: "{ tags -> tags.job_name in [ 'kubernetes-cadvisor', 'kube-state-metrics' ] }" # The OpenTelemetry job name
-expSuffix: tag({tags -> tags.cluster = 'k8s-cluster::' + tags.cluster}).endpoint(['cluster'] , ['service'], Layer.K8S)
+expSuffix: service(['cluster' , 'service', 'oo'], '::', Layer.K8S_SERVICE)
Review comment:
What does `'oo'` mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #8772: Adjust MAL for V9 and update UI template
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #8772:
URL: https://github.com/apache/skywalking/pull/8772#issuecomment-1083999206
Envoy metric naming format changes, need some fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #8772: Adjust MAL for V9 and update UI template
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #8772:
URL: https://github.com/apache/skywalking/pull/8772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org