You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "blaginin (via GitHub)" <gi...@apache.org> on 2024/11/09 14:12:06 UTC

[PR] Allow aggregation without projection in Unparser [datafusion]

blaginin opened a new pull request, #13326:
URL: https://github.com/apache/datafusion/pull/13326

   ## Which issue does this PR close?
   
   Closes #12773
   
   ## Rationale for this change
   
   When parsing a query into a logical plan, aggregation precedes projection. But optimiser can eliminate projection, leaving aggregation as a top node. This is not expected by `select_to_sql_recursively` because it always handles projection and aggregation together. 
   
   ## What changes are included in this PR?
   
   Added a separate branch if aggregation is the top node. 
   
   ## Are these changes tested?
   
   Yes, added a new test
   
   ## Are there any user-facing changes?
   
   No
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Allow aggregation without projection in `Unparser` [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #13326:
URL: https://github.com/apache/datafusion/pull/13326


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org