You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/11 06:53:19 UTC
[GitHub] [rocketmq-connect] liyijuan opened a new pull request, #188: README
liyijuan opened a new pull request, #188:
URL: https://github.com/apache/rocketmq-connect/pull/188
## What is the purpose of the change
1. add tips about jvm heap parameter settings, for the user maybe a student just for a test
2. add some releated document links
3. add tips about pluginPaths
## Brief changelog
1. add document links in the front
2. tips about jvm heap parameters
```
JAVA_OPT="${JAVA_OPT} -server -Xms256m -Xmx256m"
```
3. tips about pluginPaths
```
# 补充：将 Connector 相关实现插件保存到指定文件夹
# pluginPaths=/usr/local/connector-plugins/*
```
## Verifying this change
based on the changed pluginPaths, rerun the file-connect-sample
the result is following :
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq-connect/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] odbozhou merged pull request #188: [ISSUE #187]Add JVM Parameters Configuration illustrate to README.md
Posted by GitBox <gi...@apache.org>.
odbozhou merged PR #188:
URL: https://github.com/apache/rocketmq-connect/pull/188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] odbozhou commented on pull request #188: [ISSUE #187]Add JVM Parameters Configuration illustrate to README.md
Posted by GitBox <gi...@apache.org>.
odbozhou commented on PR #188:
URL: https://github.com/apache/rocketmq-connect/pull/188#issuecomment-1181346793
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org