You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2016/01/06 22:25:34 UTC

[Bug 58813] New: Incoming requests hang after a website using the ISAPI connector is restarted

https://bz.apache.org/bugzilla/show_bug.cgi?id=58813

            Bug ID: 58813
           Summary: Incoming requests hang after a website using the ISAPI
                    connector is restarted
           Product: Tomcat Connectors
           Version: 1.2.33
          Hardware: PC
            Status: NEW
          Severity: regression
          Priority: P2
         Component: isapi
          Assignee: dev@tomcat.apache.org
          Reporter: matthewreiter@hotmail.com

OS: Windows Server 2012 R2 Standard

If isapi_redirect.dll is configured at the website level (rather than
globally), when the website is restarted using IIS Manager, the ISAPI
redirector is restarted, too. At this point any further HTTP requests will hang
until IIS is restarted.

I've traced the problem back to this commit:
commit 2f209a0d25e379b7cb29a9aad74dd71a95471ae5
Author: Mladen Turk <mt...@apache.org>
Date:   Tue Mar 6 12:21:02 2012 +0000

    Use global mutex instead critical section so that multiple instance don't
in
it at once in case IIS starts multiple processes

    git-svn-id: https://svn.apache.org/repos/asf/tomcat/jk/trunk@1297439
13f7953
5-47bb-0310-9956-ffa450edef68

:040000 040000 ac36df68c573630431521b9d616e18234029109c
040c8ea72fdcaedbe0b058c0
596a2448a505d768 M      native

In TerminateFilter (in jk_isapi_plugin.c), ReleaseMutex is being called with
the address of the init_cs variable rather than its value, causing init_cs to
never be released. As a result, when GetExtensionVersion is subsequently
called, it is unable to acquire init_cs and so the plugin never finishes
initializing. I was able to confirm that removing the extra "&" fixes the
problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 58813] Incoming requests hang after a website using the ISAPI connector is restarted

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58813

--- Comment #4 from Christian Swoboda <e9...@stud2.tuwien.ac.at> ---
Thanks a lot for the quick conformation!

I meanwhile found my old Visual C++ 6.0 CD and will build a "custom" version as
well, because I can't put the official version into production with this bug!

@Source owner of jk_isapi_plugin.c:
Please, please, please fix this "typo" in the next official version!
Pretty please, with sugar on top?!

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 58813] Incoming requests hang after a website using the ISAPI connector is restarted

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58813

Matthew Reiter <ma...@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |Windows Server 2012

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 58813] Incoming requests hang after a website using the ISAPI connector is restarted

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58813

--- Comment #3 from Matthew Reiter <ma...@hotmail.com> ---
Yes, it is.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 58813] Incoming requests hang after a website using the ISAPI connector is restarted

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58813

--- Comment #8 from Christian Swoboda <e9...@stud2.tuwien.ac.at> ---

GREAT! 

Will there be an official release of 1.2.42 soon?

Thanks a lot
  swobi

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 58813] Incoming requests hang after a website using the ISAPI connector is restarted

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58813

Matthew Reiter <ma...@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Matthew Reiter <ma...@hotmail.com> ---
This bug applies to all versions from 1.2.33 to the latest in trunk (1.2.42).

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 58813] Incoming requests hang after a website using the ISAPI connector is restarted

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58813

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |murilo.v.andretta@gmail.com

--- Comment #6 from Mark Thomas <ma...@apache.org> ---
*** Bug 59334 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 58813] Incoming requests hang after a website using the ISAPI connector is restarted

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58813

--- Comment #2 from Christian Swoboda <e9...@stud2.tuwien.ac.at> ---
Hi!

I added your patch description to the following silimar bug:
https://bz.apache.org/bugzilla/show_bug.cgi?id=59334

It seems to be the same bug.

Here (again) the details of what should be done:

TerminateFilter (in jk_isapi_plugin.c) 

version 1.2.41 
Line 2424:    ReleaseMutex(&init_cs);

should be:    ReleaseMutex(init_cs);


That's the patch you have tested successfully, right?

kind regards
   swobi

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 58813] Incoming requests hang after a website using the ISAPI connector is restarted

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58813

--- Comment #9 from Mark Thomas <ma...@apache.org> ---
Good question. It has been over a year since the last release. I'll start a
discussion on the dev list.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 58813] Incoming requests hang after a website using the ISAPI connector is restarted

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58813

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thomas.reiser@speed4trade.c
                   |                            |om

--- Comment #7 from Mark Thomas <ma...@apache.org> ---
*** Bug 59092 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 58813] Incoming requests hang after a website using the ISAPI connector is restarted

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58813

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Mark Thomas <ma...@apache.org> ---
Fixed in trunk for 1.2.42 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org