You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "thomas-vt (via GitHub)" <gi...@apache.org> on 2023/05/03 13:16:41 UTC
[GitHub] [airflow] thomas-vt opened a new pull request, #31040: Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter
thomas-vt opened a new pull request, #31040:
URL: https://github.com/apache/airflow/pull/31040
<!--
This PR is for integrating kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter
https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack
Reference
closes: #28779
related: #28779
@sudeepgupta90 @potiuk @jedcunningham @dstandish @ephraimbuddy please review
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter [airflow]
Posted by "lucasfcnunes (via GitHub)" <gi...@apache.org>.
lucasfcnunes commented on PR #31040:
URL: https://github.com/apache/airflow/pull/31040#issuecomment-2155246358
> Hi @sudeepgupta90 I also have use case where id like to have the serviceMonitor integrated into the airflow chart (currently i create my own serviceMonitor, airflow chart is a dependency).
>
> I don't mind pushing this forward, could you provide a quick guide on the chart test framework, where the tests are or how are they executed (i will have to open a new PR)
@ArieLevs we did the same (https://github.com/yurivenancio30/airflow-chart/blob/main/charts/postgresql/templates/read/servicemonitor.yaml)
FYI @yurivenancio30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sudeepgupta90 commented on pull request #31040: Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter
Posted by "sudeepgupta90 (via GitHub)" <gi...@apache.org>.
sudeepgupta90 commented on PR #31040:
URL: https://github.com/apache/airflow/pull/31040#issuecomment-1534093840
You would also need to have appropriate tests before this can be merged @thomas-vt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] thomas-vt commented on a diff in pull request #31040: Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter
Posted by "thomas-vt (via GitHub)" <gi...@apache.org>.
thomas-vt commented on code in PR #31040:
URL: https://github.com/apache/airflow/pull/31040#discussion_r1183933283
##########
chart/templates/_tplvalues.tpl:
##########
@@ -0,0 +1,13 @@
+{{/* vim: set filetype=mustache: */}}
Review Comment:
The function is now removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter [airflow]
Posted by "ArieLevs (via GitHub)" <gi...@apache.org>.
ArieLevs commented on PR #31040:
URL: https://github.com/apache/airflow/pull/31040#issuecomment-1993897949
Hi @sudeepgupta90
I also have use case where id like to have the serviceMonitor integrated into the airflow chart (currently i create my own serviceMonitor, airflow chart is a dependency).
I don't mind pushing this forward, could you provide a quick guide on the chart test framework, where the tests are or how are they executed (i will have to open a new PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sudeepgupta90 commented on a diff in pull request #31040: Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter
Posted by "sudeepgupta90 (via GitHub)" <gi...@apache.org>.
sudeepgupta90 commented on code in PR #31040:
URL: https://github.com/apache/airflow/pull/31040#discussion_r1183792504
##########
chart/templates/statsd/statsd-servicemonitor.yaml:
##########
@@ -0,0 +1,48 @@
+{{- if and .Values.statsd.enabled .Values.statsd.serviceMonitor.enabled }}
+apiVersion: monitoring.coreos.com/v1
+kind: ServiceMonitor
+metadata:
+ name: {{ .Release.Name }}
+ {{- if .Values.statsd.serviceMonitor.namespace }}
+ namespace: {{ .Values.statsd.serviceMonitor.namespace }}
+ {{- else }}
+ namespace: {{ .Release.Namespace }}
+ {{- end }}
+ {{- if .Values.statsd.serviceMonitor.labels }}
+ labels:
+ {{- include "common.tplvalues.render" ( dict "value" .Values.statsd.serviceMonitor.labels "context" $ ) | nindent 4 }}
Review Comment:
```suggestion
{{- .Values.statsd.serviceMonitor.labels | toYaml | nindent 4 }}
```
##########
chart/templates/statsd/statsd-servicemonitor.yaml:
##########
@@ -0,0 +1,48 @@
+{{- if and .Values.statsd.enabled .Values.statsd.serviceMonitor.enabled }}
+apiVersion: monitoring.coreos.com/v1
+kind: ServiceMonitor
+metadata:
+ name: {{ .Release.Name }}
+ {{- if .Values.statsd.serviceMonitor.namespace }}
+ namespace: {{ .Values.statsd.serviceMonitor.namespace }}
+ {{- else }}
+ namespace: {{ .Release.Namespace }}
+ {{- end }}
+ {{- if .Values.statsd.serviceMonitor.labels }}
+ labels:
+ {{- include "common.tplvalues.render" ( dict "value" .Values.statsd.serviceMonitor.labels "context" $ ) | nindent 4 }}
+ {{- end }}
+ {{- if .Values.commonAnnotations }}
+ annotations:
Review Comment:
```suggestion
annotations:
{{- .Values.commonAnnotations | toYaml | nindent 4}}
```
##########
chart/templates/_tplvalues.tpl:
##########
@@ -0,0 +1,13 @@
+{{/* vim: set filetype=mustache: */}}
Review Comment:
What's the need for this special function? We can simply have the label values as is, no?
##########
chart/templates/statsd/statsd-servicemonitor.yaml:
##########
@@ -0,0 +1,48 @@
+{{- if and .Values.statsd.enabled .Values.statsd.serviceMonitor.enabled }}
+apiVersion: monitoring.coreos.com/v1
+kind: ServiceMonitor
+metadata:
+ name: {{ .Release.Name }}
+ {{- if .Values.statsd.serviceMonitor.namespace }}
+ namespace: {{ .Values.statsd.serviceMonitor.namespace }}
+ {{- else }}
+ namespace: {{ .Release.Namespace }}
+ {{- end }}
+ {{- if .Values.statsd.serviceMonitor.labels }}
+ labels:
+ {{- include "common.tplvalues.render" ( dict "value" .Values.statsd.serviceMonitor.labels "context" $ ) | nindent 4 }}
Review Comment:
Why would these label values have a template?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #31040: Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #31040:
URL: https://github.com/apache/airflow/pull/31040#issuecomment-1533015216
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #31040: Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #31040: Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter
URL: https://github.com/apache/airflow/pull/31040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #31040: Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31040:
URL: https://github.com/apache/airflow/pull/31040#issuecomment-1596318710
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter [airflow]
Posted by "yurivenancio30 (via GitHub)" <gi...@apache.org>.
yurivenancio30 commented on PR #31040:
URL: https://github.com/apache/airflow/pull/31040#issuecomment-1930559885
Any updates?!?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added kube-prometheus-stack servicemonitor to gather metrics from Airflow statsd exporter [airflow]
Posted by "shalberd (via GitHub)" <gi...@apache.org>.
shalberd commented on PR #31040:
URL: https://github.com/apache/airflow/pull/31040#issuecomment-2152580688
yeah, having that option, especially when statsd is enabled anyways ... is really so useful, no reason not to include ServiceMonitor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org