You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/03 16:55:05 UTC

[GitHub] [spark] zero323 edited a comment on pull request #29938: {SPARK-33061][SQL] Expose inverse hyperbolic trig functions through sql.functions API

zero323 edited a comment on pull request #29938:
URL: https://github.com/apache/spark/pull/29938#issuecomment-703132270


   Sure. I asked there why we provide wrappers around certain functions and not other and  @HyukjinKwon pointed out this:
   
   https://github.com/apache/spark/blob/5af62a2ec74356ce1a97c1371321b3424b674289/sql/core/src/main/scala/org/apache/spark/sql/functions.scala#L45-L56
   
   I don't insist that it necessarily applies here (though arguably, average user doesn't need hyperbolic trig functions on daily basis), just giving some context :)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org