You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/23 12:33:06 UTC

[GitHub] [incubator-inlong] EMsnap commented on a diff in pull request #4308: [INLONG-4306][Sort] Parameter error connector of file system

EMsnap commented on code in PR #4308:
URL: https://github.com/apache/incubator-inlong/pull/4308#discussion_r879147932


##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/load/FileSystemLoadNode.java:
##########
@@ -79,13 +77,13 @@ public FileSystemLoadNode(@JsonProperty("id") String id,
             @Nullable @JsonProperty("sinkParallelism") Integer sinkParallelism,
             @JsonProperty("properties") Map<String, String> properties,
             @JsonProperty("parFields") List<FieldInfo> partitionFields,
-            @JsonProperty("watermarkField") WatermarkField watermarkField) {
+            @JsonProperty("serverTimeZone") String serverTimeZone) {
         super(id, name, fields, fieldRelationShips, filters, null, sinkParallelism, properties);
         this.format = Preconditions.checkNotNull(format, "format type is null");
         this.path = Preconditions.checkNotNull(path, "path is null");
         this.partitionFields = partitionFields;
-        this.watermarkField = watermarkField;
-        this.name = name;
+        this.tampTableName = name;

Review Comment:
   tampTableName typo?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org