You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/19 09:54:14 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4808: [Improvement][Api] add @Override on the Override method
codecov-io commented on pull request #4808:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4808#issuecomment-781966500
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808?src=pr&el=h1) Report
> Merging [#4808](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808?src=pr&el=desc) (d275e1c) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/61397b338af4bbfb8add5fec4b765ffc1b519576?el=desc) (61397b3) will **decrease** coverage by `0.19%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4808 +/- ##
============================================
- Coverage 45.45% 45.25% -0.20%
+ Complexity 3416 3398 -18
============================================
Files 538 538
Lines 23047 23047
Branches 2686 2686
============================================
- Hits 10475 10429 -46
- Misses 11639 11687 +48
+ Partials 933 931 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...duler/api/service/impl/AccessTokenServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9BY2Nlc3NUb2tlblNlcnZpY2VJbXBsLmphdmE=) | `77.61% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| [...eduler/api/service/impl/AlertGroupServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9BbGVydEdyb3VwU2VydmljZUltcGwuamF2YQ==) | `95.23% <ø> (ø)` | `13.00 <0.00> (ø)` | |
| [...hinscheduler/api/service/impl/BaseServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9CYXNlU2VydmljZUltcGwuamF2YQ==) | `92.59% <ø> (ø)` | `15.00 <0.00> (ø)` | |
| [...uler/api/service/impl/DataAnalysisServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9EYXRhQW5hbHlzaXNTZXJ2aWNlSW1wbC5qYXZh) | `98.91% <ø> (ø)` | `30.00 <0.00> (ø)` | |
| [...eduler/api/service/impl/DataSourceServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9EYXRhU291cmNlU2VydmljZUltcGwuamF2YQ==) | `55.13% <ø> (ø)` | `33.00 <0.00> (ø)` | |
| [...cheduler/api/service/impl/ExecutorServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9FeGVjdXRvclNlcnZpY2VJbXBsLmphdmE=) | `37.08% <ø> (ø)` | `20.00 <0.00> (ø)` | |
| [...nscheduler/api/service/impl/LoggerServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Mb2dnZXJTZXJ2aWNlSW1wbC5qYXZh) | `77.77% <ø> (ø)` | `11.00 <0.00> (ø)` | |
| [...scheduler/api/service/impl/MonitorServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Nb25pdG9yU2VydmljZUltcGwuamF2YQ==) | `13.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...vice/impl/ProcessDefinitionVersionServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Qcm9jZXNzRGVmaW5pdGlvblZlcnNpb25TZXJ2aWNlSW1wbC5qYXZh) | `96.00% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| [...r/api/service/impl/ProcessInstanceServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Qcm9jZXNzSW5zdGFuY2VTZXJ2aWNlSW1wbC5qYXZh) | `74.22% <ø> (ø)` | `36.00 <0.00> (ø)` | |
| ... and [21 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808?src=pr&el=footer). Last update [61397b3...d275e1c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4808?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org