You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/10/06 16:46:35 UTC
[GitHub] [activemq-artemis] gemmellr opened a new pull request #3789: ARTEMIS-3520: set Open hint upon redirect/refusal of AMQP connections
gemmellr opened a new pull request #3789:
URL: https://github.com/apache/activemq-artemis/pull/3789
Set the Open frame failure hint property when the broker balancer decides to redirect or refuse an AMQP connection, so aware clients know they need not proceed on receipt of the Open as a Close will follow. Adds some more direct tests of the protocol behaviour during refusal or redirect of initial connection by the balancer.
Also adds some context to failure messages from other existing Redirect tests, as some asserts are in loops and cant be fully reasoned about without detail then no longer available (meant to put that in a separate commit, but didn't seem worth separating it again once I forgot to commit it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3789: ARTEMIS-3520: set Open hint upon redirect/refusal of AMQP connections
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3789:
URL: https://github.com/apache/activemq-artemis/pull/3789#issuecomment-936691859
Oops, I was in the test dir when I fixed checkstyle issues, missed the other bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully merged pull request #3789: ARTEMIS-3520: set Open hint upon redirect/refusal of AMQP connections
Posted by GitBox <gi...@apache.org>.
gtully merged pull request #3789:
URL: https://github.com/apache/activemq-artemis/pull/3789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully commented on pull request #3789: ARTEMIS-3520: set Open hint upon redirect/refusal of AMQP connections
Posted by GitBox <gi...@apache.org>.
gtully commented on pull request #3789:
URL: https://github.com/apache/activemq-artemis/pull/3789#issuecomment-937637670
this sorts the NPE in the new balancer example, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully commented on pull request #3789: ARTEMIS-3520: set Open hint upon redirect/refusal of AMQP connections
Posted by GitBox <gi...@apache.org>.
gtully commented on pull request #3789:
URL: https://github.com/apache/activemq-artemis/pull/3789#issuecomment-937637670
this sorts the NPE in the new balancer example, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully merged pull request #3789: ARTEMIS-3520: set Open hint upon redirect/refusal of AMQP connections
Posted by GitBox <gi...@apache.org>.
gtully merged pull request #3789:
URL: https://github.com/apache/activemq-artemis/pull/3789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org