You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Hegner, Travis" <TH...@trilliumit.com> on 2016/02/02 20:18:35 UTC
Shephard Reqeust: patch for MESOS-4370
Hello All,
I am requesting a review of a patch to MESOS-4370. Here are all of the pertinent links:
https://issues.apache.org/jira/browse/MESOS-4370
https://reviews.apache.org/r/43093/
https://github.com/apache/mesos/pull/90
I have tagged Benjamin Hindman as a reviewer already on the review board as he was listed as the maintainer of the Docker containerizer. I have not had any previous contact with him. My apologies if this is bad etiquette.
The patch eliminates the use of the deprecated "NetworkSettings.IPAddress" field in the docker inspect output, and replaces it with using the appropriate "NetworkSettings.Networks.<name>.IPAddress" field, where <name> is the name of the network as it was passed to the last "--net <name>" on the docker run command. The network name is available and queried from the "HostConfig.NetworkMode" field in the inspect output.
Thanks,
Travis Hegner
RE: Shephard Reqeust: patch for MESOS-4370
Posted by "Hegner, Travis" <TH...@trilliumit.com>.
At the risk of sounding like a complainer: I feel that there is a very high barrier to entry when trying to help with this project. Perhaps many users are spoiled by github (myself included) because it's easy to suggest and discuss changes. At the risk of sounding lazy: I did read the submit-a-patch page and submitted the pull request on github anyway, in the hopes that I could avoid "going through all that work" to submit a patch. I was not confused, just hopeful. :)
In the end, my desire to get the patch merged upstream was stronger than my desire to maintain a separate fork of mesos. That is why I am now subscribed to this list.
In my opinion, the barrier to entry being so high to contribute will hinder community growth. If we weren't intending to use mesos in a production environment, I would never have submitted any patches back at all. Having to create and maintain multiple different user accounts, on multiple different tools, with multiple different interfaces is kind of burdensome. Not to mention that I personally do not like an email heavy workflow (despite my emails being novels, I know). I would have to assume that project maintainers are spending a lot of unnecessary time working with so many different tools, and having such a complicated workflow.
I believe that the current system is great to attract developers, who want to program something. However, difficult for "users" (like me) of the project who may be just savvy enough to troubleshoot, diagnose, and repair issues that they actually encounter when using the project, rather than just choosing a JIRA at random to work on.
I completely understand wanting to keep out "riff-raff" (for lack of a better term), but I believe that the high barrier to entry could be keeping out good suggestions, and submissions as well.
Of course, the project maintainers are free to do as they choose, I just felt obligated to share my opinion on the matter. I don't believe more documentation will solve that issue, and disabling pull requests may deter even more potential community members from participating. That said, ignoring pull requests may do even more harm than not allowing them in the first place.
Sorry if I'm being a bit too forward here, but as an outsider really trying to help, this is what I see.
Thanks,
Travis
-----Original Message-----
From: haosdent [mailto:haosdent@gmail.com]
Sent: Tuesday, February 2, 2016 8:27 PM
To: dev <de...@mesos.apache.org>
Subject: Re: Shephard Reqeust: patch for MESOS-4370
How about rename submitting-a-patch to CONTRIBUTING.md or create CONTRIBUTING.md which would show when user create pull request in github? Furthermore, because I saw we also submit doc through Review board, how about disable pull request in Github which let user confuse?
On Wed, Feb 3, 2016 at 4:41 AM, Hegner, Travis <TH...@trilliumit.com>
wrote:
> OK then, Thanks.
>
> Consider this message a formal request for contributor permissions so
> that I can assign the JIRA to myelf.
>
> Travis
>
> -----Original Message-----
> From: Kapil Arya [mailto:kapil@mesosphere.io]
> Sent: Tuesday, February 2, 2016 3:04 PM
> To: dev <de...@mesos.apache.org>
> Subject: Re: Shephard Reqeust: patch for MESOS-4370
>
> Thanks for the explanation, Greg!!
>
> Travis,
>
> Thanks for contributing to Mesos. Please go through the contributor
> guidelines as suggested by Greg. I can then shepherd the patch for you.
>
> Best,
> Kapil
>
>
> On Tue, Feb 2, 2016 at 2:56 PM, Greg Mann <gr...@mesosphere.io> wrote:
> > Hi Travis,
> > Thanks for your contribution! It's always great to see new
> > contributors :-)
> >
> > A couple things regarding your patch:
> > Please have a look at the contribution guidelines here:
> > http://mesos.apache.org/documentation/latest/submitting-a-patch/
> >
> > The standard protocol when addressing a JIRA issue is to assign the
> > issue to yourself on JIRA, and then find a "Shepherd" for the ticket
> > before coding begins. The shepherd is a Mesos committer who will
> > work with you to design the patch, and then commit it once it's complete.
> >
> > It also looks like the ticket you've been working on is currently in
> > the "Open" state. This means that it hasn't been marked as "Accepted"
> > by an existing contributor, signifying that someone thinks it's an
> > issue worth pursuing. In this case, the first step is to begin a
> > discussion on the issue by commenting on JIRA, and perhaps drawing
> > attention to it via this mailing list, to see how the community
> > thinks
> we should proceed.
> >
> > I would recommend that you first assign MESOS-4370 to yourself (this
> > will require contributor permissions on JIRA, which can be secured
> > with a short email to this mailing list requesting them). You
> > already did a good job of summarizing your approach in the
> > description of your review request, which you also posted on JIRA,
> > so hopefully this thread will draw the attention of some interested
> > parties who can provide some feedback, as well as a committer who
> > might have some time to shepherd the ticket for you :-)
> >
> > Cheers, and welcome!
> > Greg
> >
> >
> > On Tue, Feb 2, 2016 at 11:18 AM, Hegner, Travis
> > <TH...@trilliumit.com>
> > wrote:
> >
> >> Hello All,
> >>
> >> I am requesting a review of a patch to MESOS-4370. Here are all of
> >> the pertinent links:
> >>
> >> https://issues.apache.org/jira/browse/MESOS-4370
> >> https://reviews.apache.org/r/43093/
> >> https://github.com/apache/mesos/pull/90
> >>
> >> I have tagged Benjamin Hindman as a reviewer already on the review
> >> board as he was listed as the maintainer of the Docker containerizer.
> >> I have not had any previous contact with him. My apologies if this
> >> is
> bad etiquette.
> >>
> >> The patch eliminates the use of the deprecated
> "NetworkSettings.IPAddress"
> >> field in the docker inspect output, and replaces it with using the
> >> appropriate "NetworkSettings.Networks.<name>.IPAddress" field,
> >> where <name> is the name of the network as it was passed to the
> >> last "--net <name>" on the docker run command. The network name is
> >> available and queried from the "HostConfig.NetworkMode" field in the inspect output.
> >>
> >> Thanks,
> >> Travis Hegner
> >>
>
--
Best Regards,
Haosdent Huang
Re: Shephard Reqeust: patch for MESOS-4370
Posted by haosdent <ha...@gmail.com>.
How about rename submitting-a-patch to CONTRIBUTING.md or
create CONTRIBUTING.md which would show when user create pull request in
github? Furthermore, because I saw we also submit doc through Review board,
how about disable pull request in Github which let user confuse?
On Wed, Feb 3, 2016 at 4:41 AM, Hegner, Travis <TH...@trilliumit.com>
wrote:
> OK then, Thanks.
>
> Consider this message a formal request for contributor permissions so that
> I can assign the JIRA to myelf.
>
> Travis
>
> -----Original Message-----
> From: Kapil Arya [mailto:kapil@mesosphere.io]
> Sent: Tuesday, February 2, 2016 3:04 PM
> To: dev <de...@mesos.apache.org>
> Subject: Re: Shephard Reqeust: patch for MESOS-4370
>
> Thanks for the explanation, Greg!!
>
> Travis,
>
> Thanks for contributing to Mesos. Please go through the contributor
> guidelines as suggested by Greg. I can then shepherd the patch for you.
>
> Best,
> Kapil
>
>
> On Tue, Feb 2, 2016 at 2:56 PM, Greg Mann <gr...@mesosphere.io> wrote:
> > Hi Travis,
> > Thanks for your contribution! It's always great to see new
> > contributors :-)
> >
> > A couple things regarding your patch:
> > Please have a look at the contribution guidelines here:
> > http://mesos.apache.org/documentation/latest/submitting-a-patch/
> >
> > The standard protocol when addressing a JIRA issue is to assign the
> > issue to yourself on JIRA, and then find a "Shepherd" for the ticket
> > before coding begins. The shepherd is a Mesos committer who will work
> > with you to design the patch, and then commit it once it's complete.
> >
> > It also looks like the ticket you've been working on is currently in
> > the "Open" state. This means that it hasn't been marked as "Accepted"
> > by an existing contributor, signifying that someone thinks it's an
> > issue worth pursuing. In this case, the first step is to begin a
> > discussion on the issue by commenting on JIRA, and perhaps drawing
> > attention to it via this mailing list, to see how the community thinks
> we should proceed.
> >
> > I would recommend that you first assign MESOS-4370 to yourself (this
> > will require contributor permissions on JIRA, which can be secured
> > with a short email to this mailing list requesting them). You already
> > did a good job of summarizing your approach in the description of your
> > review request, which you also posted on JIRA, so hopefully this
> > thread will draw the attention of some interested parties who can
> > provide some feedback, as well as a committer who might have some time
> > to shepherd the ticket for you :-)
> >
> > Cheers, and welcome!
> > Greg
> >
> >
> > On Tue, Feb 2, 2016 at 11:18 AM, Hegner, Travis
> > <TH...@trilliumit.com>
> > wrote:
> >
> >> Hello All,
> >>
> >> I am requesting a review of a patch to MESOS-4370. Here are all of
> >> the pertinent links:
> >>
> >> https://issues.apache.org/jira/browse/MESOS-4370
> >> https://reviews.apache.org/r/43093/
> >> https://github.com/apache/mesos/pull/90
> >>
> >> I have tagged Benjamin Hindman as a reviewer already on the review
> >> board as he was listed as the maintainer of the Docker containerizer.
> >> I have not had any previous contact with him. My apologies if this is
> bad etiquette.
> >>
> >> The patch eliminates the use of the deprecated
> "NetworkSettings.IPAddress"
> >> field in the docker inspect output, and replaces it with using the
> >> appropriate "NetworkSettings.Networks.<name>.IPAddress" field, where
> >> <name> is the name of the network as it was passed to the last "--net
> >> <name>" on the docker run command. The network name is available and
> >> queried from the "HostConfig.NetworkMode" field in the inspect output.
> >>
> >> Thanks,
> >> Travis Hegner
> >>
>
--
Best Regards,
Haosdent Huang
RE: Shephard Reqeust: patch for MESOS-4370
Posted by "Hegner, Travis" <TH...@trilliumit.com>.
OK then, Thanks.
Consider this message a formal request for contributor permissions so that I can assign the JIRA to myelf.
Travis
-----Original Message-----
From: Kapil Arya [mailto:kapil@mesosphere.io]
Sent: Tuesday, February 2, 2016 3:04 PM
To: dev <de...@mesos.apache.org>
Subject: Re: Shephard Reqeust: patch for MESOS-4370
Thanks for the explanation, Greg!!
Travis,
Thanks for contributing to Mesos. Please go through the contributor guidelines as suggested by Greg. I can then shepherd the patch for you.
Best,
Kapil
On Tue, Feb 2, 2016 at 2:56 PM, Greg Mann <gr...@mesosphere.io> wrote:
> Hi Travis,
> Thanks for your contribution! It's always great to see new
> contributors :-)
>
> A couple things regarding your patch:
> Please have a look at the contribution guidelines here:
> http://mesos.apache.org/documentation/latest/submitting-a-patch/
>
> The standard protocol when addressing a JIRA issue is to assign the
> issue to yourself on JIRA, and then find a "Shepherd" for the ticket
> before coding begins. The shepherd is a Mesos committer who will work
> with you to design the patch, and then commit it once it's complete.
>
> It also looks like the ticket you've been working on is currently in
> the "Open" state. This means that it hasn't been marked as "Accepted"
> by an existing contributor, signifying that someone thinks it's an
> issue worth pursuing. In this case, the first step is to begin a
> discussion on the issue by commenting on JIRA, and perhaps drawing
> attention to it via this mailing list, to see how the community thinks we should proceed.
>
> I would recommend that you first assign MESOS-4370 to yourself (this
> will require contributor permissions on JIRA, which can be secured
> with a short email to this mailing list requesting them). You already
> did a good job of summarizing your approach in the description of your
> review request, which you also posted on JIRA, so hopefully this
> thread will draw the attention of some interested parties who can
> provide some feedback, as well as a committer who might have some time
> to shepherd the ticket for you :-)
>
> Cheers, and welcome!
> Greg
>
>
> On Tue, Feb 2, 2016 at 11:18 AM, Hegner, Travis
> <TH...@trilliumit.com>
> wrote:
>
>> Hello All,
>>
>> I am requesting a review of a patch to MESOS-4370. Here are all of
>> the pertinent links:
>>
>> https://issues.apache.org/jira/browse/MESOS-4370
>> https://reviews.apache.org/r/43093/
>> https://github.com/apache/mesos/pull/90
>>
>> I have tagged Benjamin Hindman as a reviewer already on the review
>> board as he was listed as the maintainer of the Docker containerizer.
>> I have not had any previous contact with him. My apologies if this is bad etiquette.
>>
>> The patch eliminates the use of the deprecated "NetworkSettings.IPAddress"
>> field in the docker inspect output, and replaces it with using the
>> appropriate "NetworkSettings.Networks.<name>.IPAddress" field, where
>> <name> is the name of the network as it was passed to the last "--net
>> <name>" on the docker run command. The network name is available and
>> queried from the "HostConfig.NetworkMode" field in the inspect output.
>>
>> Thanks,
>> Travis Hegner
>>
Re: Shephard Reqeust: patch for MESOS-4370
Posted by Kapil Arya <ka...@mesosphere.io>.
Thanks for the explanation, Greg!!
Travis,
Thanks for contributing to Mesos. Please go through the contributor
guidelines as suggested by
Greg. I can then shepherd the patch for you.
Best,
Kapil
On Tue, Feb 2, 2016 at 2:56 PM, Greg Mann <gr...@mesosphere.io> wrote:
> Hi Travis,
> Thanks for your contribution! It's always great to see new contributors :-)
>
> A couple things regarding your patch:
> Please have a look at the contribution guidelines here:
> http://mesos.apache.org/documentation/latest/submitting-a-patch/
>
> The standard protocol when addressing a JIRA issue is to assign the issue
> to yourself on JIRA, and then find a "Shepherd" for the ticket before
> coding begins. The shepherd is a Mesos committer who will work with you to
> design the patch, and then commit it once it's complete.
>
> It also looks like the ticket you've been working on is currently in the
> "Open" state. This means that it hasn't been marked as "Accepted" by an
> existing contributor, signifying that someone thinks it's an issue worth
> pursuing. In this case, the first step is to begin a discussion on the
> issue by commenting on JIRA, and perhaps drawing attention to it via this
> mailing list, to see how the community thinks we should proceed.
>
> I would recommend that you first assign MESOS-4370 to yourself (this will
> require contributor permissions on JIRA, which can be secured with a short
> email to this mailing list requesting them). You already did a good job of
> summarizing your approach in the description of your review request, which
> you also posted on JIRA, so hopefully this thread will draw the attention
> of some interested parties who can provide some feedback, as well as a
> committer who might have some time to shepherd the ticket for you :-)
>
> Cheers, and welcome!
> Greg
>
>
> On Tue, Feb 2, 2016 at 11:18 AM, Hegner, Travis <TH...@trilliumit.com>
> wrote:
>
>> Hello All,
>>
>> I am requesting a review of a patch to MESOS-4370. Here are all of the
>> pertinent links:
>>
>> https://issues.apache.org/jira/browse/MESOS-4370
>> https://reviews.apache.org/r/43093/
>> https://github.com/apache/mesos/pull/90
>>
>> I have tagged Benjamin Hindman as a reviewer already on the review board
>> as he was listed as the maintainer of the Docker containerizer. I have not
>> had any previous contact with him. My apologies if this is bad etiquette.
>>
>> The patch eliminates the use of the deprecated "NetworkSettings.IPAddress"
>> field in the docker inspect output, and replaces it with using the
>> appropriate "NetworkSettings.Networks.<name>.IPAddress" field, where <name>
>> is the name of the network as it was passed to the last "--net <name>" on
>> the docker run command. The network name is available and queried from the
>> "HostConfig.NetworkMode" field in the inspect output.
>>
>> Thanks,
>> Travis Hegner
>>
Re: Shephard Reqeust: patch for MESOS-4370
Posted by Greg Mann <gr...@mesosphere.io>.
Hi Travis,
Thanks for your contribution! It's always great to see new contributors :-)
A couple things regarding your patch:
Please have a look at the contribution guidelines here:
http://mesos.apache.org/documentation/latest/submitting-a-patch/
The standard protocol when addressing a JIRA issue is to assign the issue
to yourself on JIRA, and then find a "Shepherd" for the ticket before
coding begins. The shepherd is a Mesos committer who will work with you to
design the patch, and then commit it once it's complete.
It also looks like the ticket you've been working on is currently in the
"Open" state. This means that it hasn't been marked as "Accepted" by an
existing contributor, signifying that someone thinks it's an issue worth
pursuing. In this case, the first step is to begin a discussion on the
issue by commenting on JIRA, and perhaps drawing attention to it via this
mailing list, to see how the community thinks we should proceed.
I would recommend that you first assign MESOS-4370 to yourself (this will
require contributor permissions on JIRA, which can be secured with a short
email to this mailing list requesting them). You already did a good job of
summarizing your approach in the description of your review request, which
you also posted on JIRA, so hopefully this thread will draw the attention
of some interested parties who can provide some feedback, as well as a
committer who might have some time to shepherd the ticket for you :-)
Cheers, and welcome!
Greg
On Tue, Feb 2, 2016 at 11:18 AM, Hegner, Travis <TH...@trilliumit.com>
wrote:
> Hello All,
>
> I am requesting a review of a patch to MESOS-4370. Here are all of the
> pertinent links:
>
> https://issues.apache.org/jira/browse/MESOS-4370
> https://reviews.apache.org/r/43093/
> https://github.com/apache/mesos/pull/90
>
> I have tagged Benjamin Hindman as a reviewer already on the review board
> as he was listed as the maintainer of the Docker containerizer. I have not
> had any previous contact with him. My apologies if this is bad etiquette.
>
> The patch eliminates the use of the deprecated "NetworkSettings.IPAddress"
> field in the docker inspect output, and replaces it with using the
> appropriate "NetworkSettings.Networks.<name>.IPAddress" field, where <name>
> is the name of the network as it was passed to the last "--net <name>" on
> the docker run command. The network name is available and queried from the
> "HostConfig.NetworkMode" field in the inspect output.
>
> Thanks,
> Travis Hegner
>