[GitHub] flink pull request #1517: [FLINK-3477] [runtime] Add hash-based combine stra...

[greghogan <gi...@git.apache.org>]

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1517#discussion_r70139954
  
    --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/GroupedDataSet.scala ---
    @@ -282,27 +283,57 @@ class GroupedDataSet[T: ClassTag](
       }
     
       /**
    -   * Creates a new [[DataSet]] by merging the elements of each group (elements with the same key)
    -   * using an associative reduce function.
    -   */
    +    * Creates a new [[DataSet]] by merging the elements of each group (elements with the same key)
    +    * using an associative reduce function.
    +    */
       def reduce(fun: (T, T) => T): DataSet[T] = {
    +    reduce(getCallLocationName(), fun, CombineHint.OPTIMIZER_CHOOSES)
    +  }
    +
    +  /**
    +   * Special [[reduce]] operation for explicitly telling the system what strategy to use for the
    +   * combine phase.
    +   * If null is given as the strategy, then the optimizer will pick the strategy.
    +   */
    +  def reduce(fun: (T, T) => T, strategy: CombineHint): DataSet[T] = {
    --- End diff --
    
    @fhueske or @StephanEwen since we cannot break the scala DataSet API by creating and returning a `ReduceOperator`, do you agree with G�bor's recommendation to overload `DataSet.reduce` with `CombineHint`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---