You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@causeway.apache.org by ah...@apache.org on 2023/05/05 11:08:55 UTC

[causeway] 01/01: Merge pull request #1629 from apache/3051.validate.memberId.clash

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/causeway.git

commit 821df92764f9f4edb14a4c5d151f571b97b6256d
Merge: 309658d098 9866dd2d5e
Author: Andi Huber <ah...@apache.org>
AuthorDate: Fri May 5 13:08:49 2023 +0200

    Merge pull request #1629 from apache/3051.validate.memberId.clash
    
    CAUSEWAY-3051: new MM validator to detect member-id clashes

 .../org/apache/causeway/applib/Identifier.java     |   8 +-
 .../config/beans/CausewayBeanTypeRegistry.java     |  18 +-
 .../progmodel/ProgrammingModelConstants.java       |   8 +-
 .../action/ActionAnnotationFacetFactory.java       |   6 +-
 ...reteTypeToBeIncludedWithMetamodelValidator.java |  45 ++--
 ...nChoicesForCollectionParameterFacetFactory.java |   2 +-
 .../actions/action/ActionOverloadingValidator.java |  37 ++-
 .../annotation/HomePageFacetAnnotationFactory.java |  20 +-
 .../actions/layout/ActionLayoutFacetFactory.java   |   6 +-
 .../CollectionAnnotationFacetFactory.java          |   6 +-
 .../layout/CollectionLayoutFacetFactory.java       |   6 +-
 .../annotation/SortedByFacetAnnotationFactory.java |   2 +-
 .../metamodel/facets/jaxb/JaxbFacetFactory.java    |   2 +-
 .../BookmarkPolicyFacetFallbackFactory.java        |   2 +-
 .../DomainObjectAnnotationFacetFactory.java        |  11 +-
 .../DomainServiceFacetAnnotationFactory.java       |   2 +-
 .../logicaltype/LogicalTypeMalformedValidator.java |  56 +++--
 .../LogicalTypeFacetFromClassNameFactory.java      |   2 +-
 .../NavigableParentAnnotationFacetFactory.java     |   2 +-
 .../annotation/TitleAnnotationFacetFactory.java    |   2 +-
 .../object/viewmodel/ViewModelFacetFactory.java    |   2 +-
 .../parameter/ParameterAnnotationFacetFactory.java |   6 +-
 .../property/PropertyAnnotationFacetFactory.java   |  13 +-
 .../propertylayout/PropertyLayoutFacetFactory.java |   6 +-
 .../ValueSemanticsAnnotationFacetFactory.java      |  10 +-
 .../core/metamodel/layout/DeweyOrderSet.java       |  12 +-
 ...tionEnforcesMetamodelContributionValidator.java |  18 +-
 .../MethodPrefixBasedFacetFactoryAbstract.java     |  22 +-
 ...tProcessor.java => MetaModelPostProcessor.java} |  21 +-
 ...ct.java => MetaModelPostProcessorAbstract.java} |   6 +-
 ...ssOnActionFromConfiguredRegexPostProcessor.java |   4 +-
 .../all/DescribedAsFromTypePostProcessor.java      |   4 +-
 ...stProcessor.java => SanityChecksValidator.java} |  51 ++--
 .../i18n/SynthesizeObjectNamingPostProcessor.java  |   4 +-
 .../all/i18n/TranslationPostProcessor.java         |   4 +-
 .../authorization/AuthorizationPostProcessor.java  |   4 +-
 ...ynthesizeDomainEventsForMixinPostProcessor.java |   4 +-
 ...NavigationFacetFromHiddenTypePostProcessor.java |   4 +-
 .../object/ProjectionFacetsPostProcessor.java      |   4 +-
 .../param/ChoicesAndDefaultsPostProcessor.java     |   4 +-
 .../param/TypicalLengthFromTypePostProcessor.java  |   4 +-
 .../DisabledFromImmutablePostProcessor.java        |   4 +-
 .../core/metamodel/progmodel/ProgrammingModel.java |  29 +--
 .../progmodel/ProgrammingModelAbstract.java        |  14 +-
 .../progmodel/ProgrammingModelInitFilter.java      |   4 +-
 .../ProgrammingModelInitFilterDefault.java         |   4 +-
 .../dflt/ProgrammingModelFacetsJava11.java         |  15 +-
 .../title/TitlesAndTranslationsValidator.java      |  25 +-
 .../core/metamodel/spec/feature/ObjectMember.java  |   2 +
 .../specloader/SpecificationLoaderDefault.java     |  30 +--
 .../specloader/{_Util.java => _LogUtil.java}       |   2 +-
 .../core/metamodel/specloader/_ValidateUtil.java   | 125 ++++++++++
 .../specloader/facetprocessor/FacetProcessor.java  |   5 +-
 .../specloader/postprocessor/PostProcessor.java    |  69 ++----
 .../specimpl/ObjectSpecificationAbstract.java      | 123 +++++-----
 .../specimpl/_MemberIdClashReporting.java          |  89 +++++++
 ...rSortingUtils.java => _MemberSortingUtils.java} |  25 +-
 .../specimpl/dflt/ObjectSpecificationDefault.java  |  45 ++--
 .../specloader/validator/MetaModelValidator.java   |  91 +++++++-
 .../validator/MetaModelValidatorAbstract.java      |  13 ++
 ...ModelValidatorForAmbiguousMixinAnnotations.java |  45 ----
 ...etaModelValidatorForConflictingOptionality.java |  84 -------
 .../validator/MetaModelVisitingValidator.java      |  38 ---
 .../MetaModelVisitingValidatorAbstract.java        |  45 ----
 .../validator/ValidationFailureUtils.java          | 130 +++++++++++
 .../specloader/validator/ValidationFailures.java   |  15 +-
 .../ordering/memberorder/DeweyOrderSetTest.java    |  28 +--
 .../specimpl/MixedInMemberNamingStrategyTest.java  |  73 +++---
 .../facets/TenantedAuthorizationPostProcessor.java |   4 +-
 .../PdfJsViewerFacetFromAnnotationFactory.java     |   6 +-
 .../jdo/metamodel/JdoProgrammingModel.java         |   4 +-
 .../query/JdoQueryAnnotationFacetFactory.java      |   5 +-
 ...ava => MetaModelValidatorForJdoqlAbstract.java} |  16 +-
 ...a => MetaModelValidatorForJdoqlFromClause.java} |   6 +-
 ...MetaModelValidatorForJdoqlVariablesClause.java} |   6 +-
 ...BigDecimalFromColumnAnnotationFacetFactory.java |   2 +-
 .../MandatoryFromColumnAnnotationFacetFactory.java |   2 +-
 ...xLengthFromJdoColumnAnnotationFacetFactory.java |   2 +-
 .../DomainModelTest_usingBadDomain.java            |  30 ++-
 .../testdomain/model/bad/InvalidMemberIdClash.java | 258 +++++++++++++++++++++
 80 files changed, 1201 insertions(+), 762 deletions(-)