You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by echobravopapa <gi...@git.apache.org> on 2017/03/17 22:03:55 UTC
[GitHub] geode-native pull request #61: GEODE-2687: test for ssl auth failure:
GitHub user echobravopapa opened a pull request:
https://github.com/apache/geode-native/pull/61
GEODE-2687: test for ssl auth failure:
- Added testThinClientSSLAuthFail to QUICK list.
- removed un-needed test code.
- catching expected exception
- Add test for untrusted server cert
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/echobravopapa/geode-native feature/GEODE-2687
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode-native/pull/61.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #61
----
commit 4149cd6dc7f7fa499e0192aee5cd6407b9f73a83
Author: Ernest Burghardt <eb...@pivotal.io>
Date: 2017-03-17T21:59:24Z
GEODE-2687: test for ssl auth failure:
- Added testThinClientSSLAuthFail to QUICK list.
- removed un-needed test code.
- catching expected exception
- Add test for untrusted server cert
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #61: GEODE-2687: test for ssl auth failure:
Posted by PivotalSarge <gi...@git.apache.org>.
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/61#discussion_r106755238
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1812,17 +1812,32 @@ std::string CacheHelper::generateGeodeProperties(const std::string& path,
msg += "enable-network-partition-detection=false\n";
if (ssl) {
- msg += "jmx-manager-ssl-enabled=false\n";
- msg += "cluster-ssl-enabled=true\n";
- msg += "cluster-ssl-require-authentication=true\n";
- msg += "cluster-ssl-ciphers=TLS_RSA_WITH_AES_128_CBC_SHA\n";
- msg += "cluster-ssl-keystore-type=jks\n";
- msg += "cluster-ssl-keystore=" + keystore + "/server_keystore.jks\n";
- msg += "cluster-ssl-keystore-password=gemstone\n";
- msg += "cluster-ssl-truststore=" + keystore + "/server_truststore.jks\n";
- msg += "cluster-ssl-truststore-password=gemstone\n";
- msg += "security-username=xxxx\n";
- msg += "security-userPassword=yyyy \n";
+ if (untrustedCert){
--- End diff --
Much like keystore is a parameter to this method, could this if-then-else statement be collapsed to a single set of concatenations that use a (possibly empty) prefix string, e.g., "untrusted_"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native issue #61: GEODE-2687: test for ssl auth failure:
Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/61
I will go ahead and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #61: GEODE-2687: test for ssl auth failure:
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode-native/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---