You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Mihaly Szjatinya (Code Review)" <ge...@cloudera.org> on 2025/09/08 20:41:42 UTC
[Impala-ASF-CR] IMPALA-14013 DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
Mihaly Szjatinya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23394
Change subject: IMPALA-14013 DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
......................................................................
IMPALA-14013 DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
Similarly to 'COMPUTE INCREMENTAL STATS', 'DROP INCREMENTAL STATS' should prohibit the partition variant for Iceberg tables.
Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
---
M fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test
2 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/23394/1
--
To view, visit http://gerrit.cloudera.org:8080/23394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
Gerrit-Change-Number: 23394
Gerrit-PatchSet: 1
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
[Impala-ASF-CR] IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23394 )
Change subject: IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20486/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
Gerrit-Change-Number: 23394
Gerrit-PatchSet: 3
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Sep 2025 16:53:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23394 )
Change subject: IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
Gerrit-Change-Number: 23394
Gerrit-PatchSet: 3
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 17:06:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23394 )
Change subject: IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12492/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
Gerrit-Change-Number: 23394
Gerrit-PatchSet: 3
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 11:41:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23394 )
Change subject: IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
......................................................................
IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for
Iceberg tables
Similarly to 'COMPUTE INCREMENTAL STATS', 'DROP INCREMENTAL STATS'
should prohibit the partition variant for Iceberg tables.
Testing:
- FE: fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
- EE: tests/query_test/test_iceberg.py
Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
Reviewed-on: http://gerrit.cloudera.org:8080/23394
Reviewed-by: Noemi Pap-Takacs <np...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test
4 files changed, 39 insertions(+), 7 deletions(-)
Approvals:
Noemi Pap-Takacs: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
Gerrit-Change-Number: 23394
Gerrit-PatchSet: 4
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
[Impala-ASF-CR] IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23394 )
Change subject: IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java
File fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java:
http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@114
PS2, Line 114: if (partitionSet_ != null) {
What about merging the two ifs from L113 and L119 (OR) and print a more general error message?
Like: ("DROP INCREMENTAL STATS... PARTITION not supported for table " + tableName_);
or: ("DROP INCREMENTAL STATS... PARTITION is only supported for Hive tables");
http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@115
PS2, Line 115: DROP INCREMENTAL ...
DROP INCREMENTAL STATS ...
http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@116
PS2, Line 116: non-HDFS
Should be "non-filesystem-based"
FeFsTable is the common interface for all tables that are filesystem-based, like legacy Hive table format, Hive ACID and Iceberg.
HDFS is one of these filesystems, but these table formats can be on Ozone or object storage (S3) as well, so referring to these tables as 'HDFS' or 'non-HDFS' tables is a bit misleading.
http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@121
PS2, Line 121: DROP INCREMENTAL ...
DROP INCREMENTAL STATS ...
http://gerrit.cloudera.org:8080/#/c/23394/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test:
http://gerrit.cloudera.org:8080/#/c/23394/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@391
PS2, Line 391: ---- QUERY
: DROP INCREMENTAL STATS ice_alltypes_part PARTITION (i=1);
: ---- CATCH
: DROP INCREMENTAL ... PARTITION not supported for Iceberg table
Could be an Analyzer test in AnalyzeDDLTest.
--
To view, visit http://gerrit.cloudera.org:8080/23394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
Gerrit-Change-Number: 23394
Gerrit-PatchSet: 2
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Sep 2025 12:29:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23394 )
Change subject: IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
Gerrit-Change-Number: 23394
Gerrit-PatchSet: 3
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 11:33:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
Posted by "Mihaly Szjatinya (Code Review)" <ge...@cloudera.org>.
Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/23394 )
Change subject: IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
......................................................................
Patch Set 2:
(5 comments)
Thank you.
http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java
File fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java:
http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@114
PS2, Line 114: if (partitionSet_ != null) {
> What about merging the two ifs from L113 and L119 (OR) and print a more gen
Hmm, I would leave this as is IYDM. It is from ComputeStatsStmt and I can see similar pattern a lot in these files.
http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@115
PS2, Line 115: DROP INCREMENTAL ...
> DROP INCREMENTAL STATS ...
Ack, fixed also in ComputeStatsStmt
http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@116
PS2, Line 116: non-HDFS
> Should be "non-filesystem-based"
That's right. Fixed also in ComputeStatsStmt
http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@121
PS2, Line 121: DROP INCREMENTAL ...
> DROP INCREMENTAL STATS ...
Ack, fixed also in ComputeStatsStmt
http://gerrit.cloudera.org:8080/#/c/23394/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test:
http://gerrit.cloudera.org:8080/#/c/23394/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@391
PS2, Line 391: ---- QUERY
: DROP INCREMENTAL STATS ice_alltypes_part PARTITION (i=1);
: ---- CATCH
: DROP INCREMENTAL ... PARTITION not supported for Iceberg table
> Could be an Analyzer test in AnalyzeDDLTest.
Done
--
To view, visit http://gerrit.cloudera.org:8080/23394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
Gerrit-Change-Number: 23394
Gerrit-PatchSet: 2
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Sep 2025 16:26:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
Posted by "Mihaly Szjatinya (Code Review)" <ge...@cloudera.org>.
Mihaly Szjatinya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/23394 )
Change subject: IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
......................................................................
IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for
Iceberg tables
Similarly to 'COMPUTE INCREMENTAL STATS', 'DROP INCREMENTAL STATS'
should prohibit the partition variant for Iceberg tables.
Testing:
- FE: fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
- EE: tests/query_test/test_iceberg.py
Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
---
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test
4 files changed, 39 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/23394/3
--
To view, visit http://gerrit.cloudera.org:8080/23394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
Gerrit-Change-Number: 23394
Gerrit-PatchSet: 3
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
[Impala-ASF-CR] IMPALA-14013 DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23394 )
Change subject: IMPALA-14013 DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20408/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
Gerrit-Change-Number: 23394
Gerrit-PatchSet: 1
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Sep 2025 21:08:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
Posted by "Mihaly Szjatinya (Code Review)" <ge...@cloudera.org>.
Mihaly Szjatinya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/23394 )
Change subject: IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
......................................................................
IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for
Iceberg tables
Similarly to 'COMPUTE INCREMENTAL STATS', 'DROP INCREMENTAL STATS'
should prohibit the partition variant for Iceberg tables.
Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
---
M fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test
2 files changed, 22 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/23394/2
--
To view, visit http://gerrit.cloudera.org:8080/23394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
Gerrit-Change-Number: 23394
Gerrit-PatchSet: 2
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23394 )
Change subject: IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20445/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283
Gerrit-Change-Number: 23394
Gerrit-PatchSet: 2
Gerrit-Owner: Mihaly Szjatinya <ms...@pm.me>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Sep 2025 11:35:22 +0000
Gerrit-HasComments: No