You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "spangaer (via GitHub)" <gi...@apache.org> on 2023/02/10 14:01:05 UTC
[GitHub] [incubator-pekko-persistence-dynamodb] spangaer opened a new pull request, #11: Retry on 50x from AWS
spangaer opened a new pull request, #11:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11
- Add DynamoRetriableException to group all exceptions on which retry should be invoked (500,502,503,504).
- Add warning when a failure happened, but retry will be invoked.
**Draft note**
I'm well aware that the rename refactor and deployment processes are still ongoing. We'll adapt these commits to the new reality as it materializes but wanted to stage the contributions already.
Also FYI @coreyoconnor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Retry on 50x from AWS [incubator-pekko-persistence-dynamodb]
Posted by "spangaer (via GitHub)" <gi...@apache.org>.
spangaer commented on PR #11:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11#issuecomment-1867415088
Someone want to give this one it's day in the sun too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-dynamodb] spangaer commented on pull request #11: Retry on 50x from AWS
Posted by "spangaer (via GitHub)" <gi...@apache.org>.
spangaer commented on PR #11:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11#issuecomment-1425911239
What am I saying, of course. This work is currently based upon the (akka) 1.1.1 release, so none of the action updates are even in here 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-dynamodb] spangaer commented on pull request #11: Retry on 50x from AWS
Posted by "spangaer (via GitHub)" <gi...@apache.org>.
spangaer commented on PR #11:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11#issuecomment-1425897398
Yes, I'm well aware that this is post initial release and Dynamo will likely be a straggler.
I think "a first time contributor non-project member" PR requires approval before the actions get run, to protect against coin miners etc.
The PR is also in draft state, but I don't think that makes any difference for actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-dynamodb] pjfanning commented on pull request #11: Retry on 50x from AWS
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #11:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11#issuecomment-1425901603
Good point about the PR need needing approval to run the CI. I get that button showing usually but not on this.
* possibly because the PR is in draft
* also PR has a merge conflict
* no worries though - when it is more ready, someone will approve it for CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-dynamodb] pjfanning commented on pull request #11: Retry on 50x from AWS
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #11:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11#issuecomment-1425889243
@spangaer I've tentatively put all these PRs in v1.1.0 milestone and just to warn you that even v1.0.0 is a long way off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Retry on 50x from AWS [incubator-pekko-persistence-dynamodb]
Posted by "Thejipppp (via GitHub)" <gi...@apache.org>.
Thejipppp commented on PR #11:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11#issuecomment-1886710198
@spangaer, could you delete the draft note from the description?
500 is the InternalServerErrorException, so that should be alright :)
The backoff behaviour is very rudimentary. The amount of retries is hardcoded to 10. The first time it retries, it takes 1 hardcoded millisecond. That time is duplicated with each try. It is hardcoded, so not configurable.
It is rather clear in[ this block.](https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11/commits/a4448c7bce0e8bcaecc4d319fed47cd6b52ebbc3#diff-0cd8c094608f52dea7e812544112dd48f9a9f144ff76e6c4622f619f235df2a1R103-R108)
This means that the last waiting time would be about half a second, and if the responses would be immediate, the total retrial process would take about 1 second. In practice, response time would be more than 0 of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Retry on 50x from AWS [incubator-pekko-persistence-dynamodb]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #11:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11#issuecomment-1903781244
I would prefer to get the PR improved. We need to document the retry behaviour. When I say document, I mean in the README.md because in this project that is the main doc source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Retry on 50x from AWS [incubator-pekko-persistence-dynamodb]
Posted by "Thejipppp (via GitHub)" <gi...@apache.org>.
Thejipppp commented on PR #11:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11#issuecomment-1886730878
Yes, there is a retry pattern which can be found on https://pekko.apache.org/docs/pekko/current/futures.html. The example there doesn't use exponential backoff, but there are other variations of the retry that can do that.
Note that this PR is more about the conditions when to retry than the actual retry mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-dynamodb] pjfanning commented on pull request #11: Retry on 50x from AWS
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #11:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11#issuecomment-1425891287
any ideas what's up with the Github Actions CI builds - none kicked off today for the PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Retry on 50x from AWS [incubator-pekko-persistence-dynamodb]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #11:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11#issuecomment-1886718961
Isn't there some utility method for exponential backoff? I know there is one for streams but there should be a future based one as well, if not that is kind of surprising as its so common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Retry on 50x from AWS [incubator-pekko-persistence-dynamodb]
Posted by "spangaer (via GitHub)" <gi...@apache.org>.
spangaer commented on PR #11:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11#issuecomment-1882737297
Compilation issue should be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Retry on 50x from AWS [incubator-pekko-persistence-dynamodb]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #11:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11#issuecomment-1883083906
@spangaer could you update the PR description? The code doesn't seem to retry for status-code=500. Would you also be able to document how to control the number of retries and the number of default retries? It would be useful to describe the backoff behaviour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Retry on 50x from AWS [incubator-pekko-persistence-dynamodb]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #11:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/11#issuecomment-1903768422
@pjfanning Should we look into reviewing this and merging it since we are on 1.1.x now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org