[jira] [Commented] (SVN-4891) Pristines-on-demand: fix disabled tests

["Julian Foad (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SVN-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518154#comment-17518154 ] 

Julian Foad commented on SVN-4891:
----------------------------------

upgrade_tests.py 7 basic_upgrade_1_0
      fails under python2 and --wc-format-version=1.15 because FileNotFoundError doesn't exist
Fails under Python2? Who cares?! Python3 is required these days. Removing from the list.

('INSTALL' on trunk says Python3 is required for dev and test. It still says "2.7 or higher" in the Windows section but I presume that's just out of date.)

> Pristines-on-demand: fix disabled tests
> ---------------------------------------
>
>                 Key: SVN-4891
>                 URL: https://issues.apache.org/jira/browse/SVN-4891
>             Project: Subversion
>          Issue Type: Bug
>            Reporter: Julian Foad
>            Assignee: Julian Foad
>            Priority: Major
>
> The following tests had been changed in the pristines-on-demand development.
> Most were disabled with the '@Wimp' decorator. (This caused some of them to give an XPASS and some an XFAIL result when run against the older WC format, and all XFAIL against the newer WC format.)
> They need to be re-enabled and fixed.
> (I am removing them from this list as and when fixed.)
> {code:java}
>     basic_tests.py 8 basic_commit_corruption(): basic corruption detection on commit
>       [[Relies on wc.text_base_path()]]
>     basic_tests.py 9 basic_update_corruption(): basic corruption detection on update
>       [[Relies on wc.text_base_path()]]
>     externals_tests.py ... ... ...:
>       update_modify_file_external(),
>       remap_file_external_with_prop_del(),
>       file_external_recorded_info():
>         existing issue (Windows only)
>     revert_tests.py 2 revert_reexpand_keyword(): revert reexpands manually contracted keyword
>       "See r1101730 and r1101817"
>     trans_tests.py 1 keywords_from_birth(): commit new files with keywords active from birth
>       [[Relies on wc.text_base_path()]]
>     trans_tests.py 3 eol_change_is_text_mod(): committing eol-style change forces text send
>       [[Relies on wc.text_base_path()]]
>     update_tests.py 57 skip_access_denied(): access denied paths should be skipped
>       [[Need to update the access denied handling in update_editor.c]]
>     upgrade_tests.py 16 replaced_files(): upgrade with base and working replaced files
>       [[Can't fetch pristines: the working copy points to file:///tmp/repo]]
>     upgrade_tests.py 7 basic_upgrade_1_0
>       fails under python2 and --wc-format-version=1.15 because FileNotFoundError doesn't exist
>     {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)