You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/03 22:49:04 UTC
[GitHub] [superset] anthcor opened a new pull request #12932: docs: update helm documentation
anthcor opened a new pull request #12932:
URL: https://github.com/apache/superset/pull/12932
### SUMMARY
Noticed https://github.com/apache/superset/issues/11363 and updated documentation to reflect a success full deployment on GKE with helm3.
```sh
$ helm version && echo && kubectl version && echo && kubectl get po -A
version.BuildInfo{Version:"v3.5.1", GitCommit:"32c22239423b3b4ba6706d450bd044baffdcf9e6", GitTreeState:"dirty", GoVersion:"go1.15.7"}
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.3", GitCommit:"1e11e4a2108024935ecfcb2912226cedeafd99df", GitTreeState:"clean", BuildDate:"2020-10-14T12:50:19Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"17+", GitVersion:"v1.17.14-gke.1600", GitCommit:"7c407f5cc8632f9af5a2657f220963aa7f1c46e7", GitTreeState:"clean", BuildDate:"2020-12-07T09:22:27Z", GoVersion:"go1.13.15b4", Compiler:"gc", Platform:"linux/amd64"}
NAMESPACE NAME READY STATUS RESTARTS AGE
default superset-77f5b77848-cchs2 1/1 Running 0 32m
default superset-init-db-8q6xw 0/1 Completed 0 32m
default superset-postgresql-0 1/1 Running 0 32m
default superset-redis-master-0 1/1 Running 0 32m
default superset-worker-86945968b4-56zdf 1/1 Running 0 32m
kube-system event-exporter-gke-666b7ffbf7-sv5wg 2/2 Running 0 93m
kube-system fluentbit-gke-42qh8 2/2 Running 0 93m
kube-system fluentbit-gke-gq544 2/2 Running 0 93m
kube-system fluentbit-gke-zjtd7 2/2 Running 0 93m
kube-system gke-metrics-agent-2qs5z 1/1 Running 0 93m
kube-system gke-metrics-agent-6n7bm 1/1 Running 0 93m
kube-system gke-metrics-agent-fjfvk 1/1 Running 0 93m
kube-system kube-dns-9c59558bb-wvmkf 4/4 Running 0 93m
kube-system kube-dns-9c59558bb-xrqnk 4/4 Running 0 93m
kube-system kube-dns-autoscaler-5c78d65cd9-q4ng2 1/1 Running 0 93m
kube-system kube-proxy-gke-superset-test-default-pool-900766ff-1cwt 1/1 Running 0 93m
kube-system kube-proxy-gke-superset-test-default-pool-900766ff-k1nt 1/1 Running 0 93m
kube-system kube-proxy-gke-superset-test-default-pool-900766ff-vvj4 1/1 Running 0 93m
kube-system l7-default-backend-5b76b455d-db4kl 1/1 Running 0 93m
kube-system metrics-server-v0.3.6-547dc87f5f-44kbj 2/2 Running 0 92m
kube-system prometheus-to-sd-7rrkt 1/1 Running 0 93m
kube-system prometheus-to-sd-fxvxk 1/1 Running 0 93m
kube-system prometheus-to-sd-thc28 1/1 Running 0 93m
kube-system stackdriver-metadata-agent-cluster-level-56d688675d-lsdqr 2/2 Running 0 92m
```
### ADDITIONAL INFORMATION
Can publish these on merge wrt https://github.com/apache/superset/blob/master/docs/README.md#to-publish
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12932: docs: update helm documentation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12932:
URL: https://github.com/apache/superset/pull/12932#issuecomment-772909006
# [Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=h1) Report
> Merging [#12932](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=desc) (89f7398) into [master](https://codecov.io/gh/apache/superset/commit/daefebb49deb255dad8514d62b6887ca1a00a723?el=desc) (daefebb) will **decrease** coverage by `8.44%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 89f7398 differs from pull request most recent head 74f4c93. Consider uploading reports for the commit 74f4c93 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12932 +/- ##
==========================================
- Coverage 77.39% 68.94% -8.45%
==========================================
Files 928 1025 +97
Lines 47024 48765 +1741
Branches 5812 5241 -571
==========================================
- Hits 36393 33623 -2770
- Misses 10488 15008 +4520
+ Partials 143 134 -9
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.83% <ø> (-5.61%)` | :arrow_down: |
| hive | `?` | |
| javascript | `61.83% <ø> (-1.31%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `67.29% <ø> (-13.83%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/components/ErrorMessage/DatabaseErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFiYXNlRXJyb3JNZXNzYWdlLnRzeA==) | `0.00% <0.00%> (-94.74%)` | :arrow_down: |
| [.../components/ErrorMessage/ParameterErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1BhcmFtZXRlckVycm9yTWVzc2FnZS50c3g=) | `6.25% <0.00%> (-90.63%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [superset-frontend/src/utils/copy.ts](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvcHkudHM=) | `11.53% <0.00%> (-84.62%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [...rontend/src/components/ErrorMessage/ErrorAlert.tsx](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yQWxlcnQudHN4) | `20.40% <0.00%> (-73.47%)` | :arrow_down: |
| [...nd/src/components/ErrorMessage/BasicErrorAlert.tsx](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Jhc2ljRXJyb3JBbGVydC50c3g=) | `35.29% <0.00%> (-64.71%)` | :arrow_down: |
| ... and [739 more](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=footer). Last update [daefebb...74f4c93](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12932: docs: update helm documentation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12932:
URL: https://github.com/apache/superset/pull/12932#issuecomment-772909006
# [Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=h1) Report
> Merging [#12932](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=desc) (89f7398) into [master](https://codecov.io/gh/apache/superset/commit/742d560636c4622aabe7ececd781f10b4870ee26?el=desc) (742d560) will **decrease** coverage by `0.19%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 89f7398 differs from pull request most recent head 2d812ed. Consider uploading reports for the commit 2d812ed to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12932 +/- ##
==========================================
- Coverage 69.14% 68.94% -0.20%
==========================================
Files 1025 1025
Lines 48765 48765
Branches 5188 5241 +53
==========================================
- Hits 33718 33623 -95
- Misses 14913 15008 +95
Partials 134 134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.83% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `61.83% <ø> (ø)` | |
| python | `67.29% <ø> (-0.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.32% <0.00%> (-3.54%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.11% <0.00%> (-2.83%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.97% <0.00%> (-2.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=footer). Last update [742d560...2d812ed](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12932: docs: update helm documentation
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12932:
URL: https://github.com/apache/superset/pull/12932#issuecomment-772909006
# [Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=h1) Report
> Merging [#12932](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=desc) (1917d22) into [master](https://codecov.io/gh/apache/superset/commit/742d560636c4622aabe7ececd781f10b4870ee26?el=desc) (742d560) will **decrease** coverage by `2.27%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12932 +/- ##
==========================================
- Coverage 69.14% 66.87% -2.28%
==========================================
Files 1025 489 -536
Lines 48765 28661 -20104
Branches 5188 0 -5188
==========================================
- Hits 33718 19166 -14552
+ Misses 14913 9495 -5418
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `66.87% <ø> (-0.76%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-16.93%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.93%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `93.47% <0.00%> (-5.98%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [555 more](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=footer). Last update [742d560...1917d22](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #12932: docs: update helm documentation
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #12932:
URL: https://github.com/apache/superset/pull/12932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] anthcor commented on pull request #12932: docs: update helm documentation
Posted by GitBox <gi...@apache.org>.
anthcor commented on pull request #12932:
URL: https://github.com/apache/superset/pull/12932#issuecomment-773387369
noting that `requirements.yaml` is deprecated in helm 3 https://helm.sh/docs/faq/#consolidation-of-requirementsyaml-into-chartyaml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a change in pull request #12932: docs: update helm documentation
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #12932:
URL: https://github.com/apache/superset/pull/12932#discussion_r597953289
##########
File path: helm/superset/Chart.yaml
##########
@@ -23,3 +23,12 @@ maintainers:
email: cychiang0823@gmail.com
url: https://github.com/cychiang
version: 0.1.0
+dependencies:
Review comment:
The API version needs to bump to v2 for requirements to live here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on pull request #12932: docs: update helm documentation
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #12932:
URL: https://github.com/apache/superset/pull/12932#issuecomment-778631150
Look like a re doing of #11763
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12932: docs: update helm documentation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12932:
URL: https://github.com/apache/superset/pull/12932#issuecomment-772909006
# [Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=h1) Report
> Merging [#12932](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=desc) (1917d22) into [master](https://codecov.io/gh/apache/superset/commit/742d560636c4622aabe7ececd781f10b4870ee26?el=desc) (742d560) will **decrease** coverage by `1.92%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12932 +/- ##
==========================================
- Coverage 69.14% 67.21% -1.93%
==========================================
Files 1025 489 -536
Lines 48765 28669 -20096
Branches 5188 0 -5188
==========================================
- Hits 33718 19271 -14447
+ Misses 14913 9398 -5515
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `67.21% <ø> (-0.41%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-16.93%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.93%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.50% <0.00%> (-0.50%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.98% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.41% <0.00%> (-0.14%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | | |
| ... and [535 more](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=footer). Last update [742d560...1917d22](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12932: docs: update helm documentation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12932:
URL: https://github.com/apache/superset/pull/12932#issuecomment-772909006
# [Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=h1) Report
> Merging [#12932](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=desc) (1917d22) into [master](https://codecov.io/gh/apache/superset/commit/742d560636c4622aabe7ececd781f10b4870ee26?el=desc) (742d560) will **decrease** coverage by `1.92%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12932 +/- ##
==========================================
- Coverage 69.14% 67.21% -1.93%
==========================================
Files 1025 489 -536
Lines 48765 28669 -20096
Branches 5188 0 -5188
==========================================
- Hits 33718 19271 -14447
+ Misses 14913 9398 -5515
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `67.21% <ø> (-0.41%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-16.93%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.93%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.50% <0.00%> (-0.50%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.98% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.41% <0.00%> (-0.14%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | | |
| ... and [535 more](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=footer). Last update [742d560...1917d22](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] anthcor commented on pull request #12932: docs: update helm documentation
Posted by GitBox <gi...@apache.org>.
anthcor commented on pull request #12932:
URL: https://github.com/apache/superset/pull/12932#issuecomment-773387369
noting that `requirements.yaml` is deprecated in helm 3 https://helm.sh/docs/faq/#consolidation-of-requirementsyaml-into-chartyaml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12932: docs: update helm documentation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12932:
URL: https://github.com/apache/superset/pull/12932#issuecomment-772909006
# [Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=h1) Report
> Merging [#12932](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=desc) (1917d22) into [master](https://codecov.io/gh/apache/superset/commit/742d560636c4622aabe7ececd781f10b4870ee26?el=desc) (742d560) will **decrease** coverage by `1.88%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12932 +/- ##
==========================================
- Coverage 69.14% 67.25% -1.89%
==========================================
Files 1025 489 -536
Lines 48765 28669 -20096
Branches 5188 0 -5188
==========================================
- Hits 33718 19282 -14436
+ Misses 14913 9387 -5526
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `67.25% <ø> (-0.37%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-16.93%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.93%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.50% <0.00%> (-0.50%)` | :arrow_down: |
| [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | | |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | | |
| [superset-frontend/src/utils/errorMessages.ts](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Vycm9yTWVzc2FnZXMudHM=) | | |
| [...ashboard/components/gridComponents/new/NewTabs.jsx](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdUYWJzLmpzeA==) | | |
| ... and [532 more](https://codecov.io/gh/apache/superset/pull/12932/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=footer). Last update [742d560...1917d22](https://codecov.io/gh/apache/superset/pull/12932?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org